Minor issues when handling ACTIVE control signal

The ACTIVE control signal is not handled in control_event_signal() which results in: control_event_signal(): Bug: Unrecognized signal 132 in control_event_signal messages when it appears.

There is also a mistype in the following comment /* "SIGACTIVE" counts as ersatz user activity. *

changed milestone to %Tor: 0.4.2.x-final

added 041-backport 042-backport 043-should BugSmashFund actualpoints::.1 component::core tor/tor consider-backport-after-0434 milestone::Tor: 0.4.2.x-final owner::nickm points::0.2 priority::medium reviewer::asn severity::normal status::merge-ready tor-dormant type::defect version::tor 0.4.0.1-alpha labels

Trac:
Description: The ACTIVE control signal is not handled in control_event_signal() which results in: control_event_signal(): Bug: Unrecognized signal 132 in control_event_signal messages when it appears.

There is also a mistype in the following comment /* "SIGACTIVE" counts as ersatz user activity. *

to

The ACTIVE control signal is not handled in control_event_signal() which results in: control_event_signal(): Bug: Unrecognized signal 132 in control_event_signal messages when it appears.

There is also a mistype in the following comment /* "SIGACTIVE" counts as ersatz user activity. *

Trac:
Owner: N/A to nickm
Status: new to accepted

Branch is bug33104_041 with PR at https://github.com/torproject/tor/pull/1696 . Should merge forward cleanly to master.

Trac:
Status: accepted to needs_review
Keywords: tor-dormant deleted, tor-dormant 041-backport? 042-backport? added
Actualpoints: N/A to .1

Trac:
Reviewer: N/A to asn

Looks good! That said, the new code (and the old code) are untested and apparently a source of bugs. I think writing a quick unittest won't be too hard. Any chance we could do that before merging?

Trac:
Status: needs_review to needs_revision

Trac:
Keywords: tor-dormant 041-backport? 042-backport? deleted, tor-dormant 041-backport? 042-backport? 043-should added

I've added a test here, though we shouldn't merge this until CI passes.

Trac:
Status: needs_revision to needs_review

Looks like CI is passing except for the rust lint issue.

Fantastic! This looks good to me. Marking as merge_ready so that Nick can merge whenever the other Rust fix gets merged.

Trac:
Status: needs_review to merge_ready

Thank you! Merged to master, marking for backport.

Trac:
Milestone: Tor: 0.4.3.x-final to Tor: 0.4.2.x-final

This seems like a minor missing feature / bug. Let's backport it to the latest stable, but no further. Users who need this feature should upgrade to the latest stable.

If 0.4.3.4 is stable (or rc?), then let's not backport to 0.4.2.

Trac:
Keywords: tor-dormant 041-backport? 042-backport? 043-should deleted, consider-backport-after-0434 tor-dormant 042-backport 043-should BugSmashFund added
Version: N/A to Tor: 0.4.0.1-alpha

The argument in favor of a backport is this: there are a pair of features (sending "SIGNAL ACTIVE" and listening for signal events with "SETEVENTS SIGNAL") which a control user might want to use together. But without this patch, every time they do so, they will spam an LD_BUG warning into the logs.

That said, I could go either way on a backport.

Oh right. So some application might spam the logs, eat the user's disk, and die?

That's probably worth a backport all the way to 0.4.1, it's only one extra release.

Trac:
Keywords: consider-backport-after-0434 tor-dormant 042-backport 043-should BugSmashFund deleted, consider-backport-after-0434 tor-dormant 041-backport 042-backport 043-should BugSmashFund added

changed time estimate to 1h 36m

added 48m of time spent

moved to tpo/core/tor#33104 (closed)