Opened 9 months ago

Closed 5 months ago

#33113 closed defect (fixed)

Bump NSIS version to 3.05

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam202005R, tbb-9.5a13
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A new NSIS version is out, 3.05, and we should switch to that one for creating our Windows installers.

Child Tickets

Change History (9)

comment:1 Changed 9 months ago by cypherpunks

Should fix #29185.

comment:2 in reply to:  1 Changed 9 months ago by gk

Replying to cypherpunks:

Should fix #29185.

What makes you think so?

comment:4 Changed 8 months ago by pili

Keywords: TorBrowserTeam202003 added; TorBrowserTeam202002 removed

We are no longer in February, moving tickets

comment:5 Changed 7 months ago by pili

Keywords: TorBrowserTeam202004 added; TorBrowserTeam202003 removed

We are no longer in March

comment:6 Changed 6 months ago by cypherpunks

tbb-9.5-must

comment:7 Changed 6 months ago by gk

Keywords: TorBrowserTeam202005R added; TorBrowserTeam202004 removed
Status: newneeds_review

bug_33113_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_33113_v2&id=c6ef475b9388e935d77722a4d5fec860b372a6a5) has a patch for review. Both x86 and x86_64 builds seem to be reproducible still and the installer is properly running in my test builds.

Tentatively marking this as child of #29185. I've no clue whether that's actually our bug that got fixed in 3.05, though. Somebody should test that. :)

comment:8 Changed 6 months ago by cypherpunks

comment:9 Changed 5 months ago by sysrqb

Keywords: tbb-9.5a13 added
Resolution: fixed
Status: needs_reviewclosed

Thanks! Merged with commit a4bf4b8a4fee918852c098edde7c89f784720d5b.

Note: See TracTickets for help on using tickets.