Opened 8 years ago

Last modified 23 months ago

#3317 new defect

Tor should lock its HiddenServiceDirs

Reported by: rransom Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We added a simple string comparison to keep me^Wusers from shooting themselves in their feet by specifying two hidden services with the same HiddenServiceDir in the same torrc, but someday we should also put a lock file in every HiddenServiceDir to prevent users from shooting themselves in their feet in more elaborate ways (e.g. using symlinks, or shared network filesystems, or multiple Tor instances).

The lock file will need to be named something other than lock (perhaps hslock), so that this won't break currently valid (but imprudent) configurations that use Tor's DataDirectory as the HiddenServiceDir for a hidden service.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by nickm

Keywords: tor-hs added

comment:2 Changed 7 years ago by nickm

Component: Tor Hidden ServicesTor

comment:3 Changed 2 years ago by nickm

Keywords: easy added
Severity: Normal

This is an easy task, if you understand how lockfiles work. We have existing lockfile code in compat.c, in our tor_lockfile_t stuff.

comment:4 Changed 23 months ago by aruna1234

what is it that the bug demands?

Note: See TracTickets for help on using tickets.