Opened 6 months ago

Last modified 6 months ago

#33193 needs_revision enhancement

Travis CI: Find and fix Python syntax errors

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: extra-review
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Here's a PR from a new contributor:
https://github.com/torproject/tor/pull/1686

Child Tickets

TicketTypeStatusOwnerSummary
#32791taskclosedFix some errors in tor's python scripts
#33192defectclosedStop assuming that /usr/bin/python exists
#33196defectnewMake flake8 test Python 3 syntax
#33203defectclosedFix typo in makedesc.py
#33204defectnewUpgrade Rust typenum for Python 3 compatibility

Change History (3)

comment:1 Changed 6 months ago by teor

Status: newneeds_revision

I'm still working on revisions with the author of the PR.

But I have a question for Nick:
Does this change belong in 0.4.3 or 0.4.4?

I think catching python syntax errors is a good idea.

And this change could enforce python 3 compatibility in all our scripts, if we change the python version to a recent python 3. (But I think we should do that in a separate ticket, in case there are any errors we need to fix.)

comment:2 Changed 6 months ago by nickm

I think 0.4.4 might be a better idea, and here's why: new code-checking tooling often comes with significant false positives or similar issues to work around, and often takes a few rounds of revision till it works right everywhere.

With that in mind, I think we should aim to do this in 0.4.4, and only do things in 0.4.3 that stabilize it. But I could probably be persuaded elsewise if I'm missing something here.

comment:3 Changed 6 months ago by teor

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final
Summary: Travis CI: Use flake8 to find Python syntax errorsTravis CI: Find and fix Python syntax errors

I think 0.4.4 is a good release to target. This is an active area right now, and there are a bunch of new volunteers, so let's do it right.

That said, if we could open the merge window for 0.4.4 soon, then it would help these volunteers collaborate from master (rather than working off each other's branches).

Note: See TracTickets for help on using tickets.