Opened 9 months ago

Closed 8 months ago

Last modified 7 months ago

#33195 closed task (fixed)

Require IPv6 tests in Travis CI

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: consider-backport-immediately, tor-ci, chutney, ipv6, network-team-roadmap-2020Q1
Cc: nickm Actual Points: 0.7
Parent ID: #33050 Points: 0.1
Reviewer: nickm Sponsor: Sponsor55-must

Description

While we're actively changing our IPv6 code, we should make sure that the macOS chutney IPv6 tests pass in Travis CI.

While I'm doing this change, I will see if there are:

  • some redundant jobs I can delete, or
  • some inactive areas that I can make fast_finish.

I think our Rust build might be a good candidate for fast_finish, we haven't changed that code much in about a year. But I should check with the team before making this change.

Child Tickets

Change History (13)

comment:1 Changed 9 months ago by teor

Parent ID: #33194#33050

comment:2 Changed 9 months ago by teor

We have active rust patches (and bugs) from two external contributors, so I can't make the rust jobs fast_finish.

comment:3 Changed 9 months ago by teor

We need to merge the #33075 backport, before making these changes.

We can delete the following redundant jobs:

  • Linux clang distcheck
    • I think this job was actually an 0.2.9 merge forward error

We need to speed up the macOS chutney IPv6 job, because it runs for 23-46 minutes:

  • run IPv4-only in Linux, and IPv6-only in macOS

comment:4 Changed 9 months ago by teor

Actual Points: 0.6
Cc: nickm added
Keywords: consider-backport-immediately ipv6 added
Reviewer: nickm
Status: assignedneeds_review

See my PRs:

Backport require IPv6 chutney to pass, remove a redundant job, reorder jobs (#33194 and #33195):

Split IPv4 and IPv6 chutney tests, and only run IPv6 on macOS (#33280 and #33303):

I think it's worth backporting these changes, they are travis-only, and should make a significant difference to CI speeds during backport merges.

comment:5 Changed 9 months ago by teor

There is also a master test branch, without #33280:

comment:6 Changed 9 months ago by nickm

Status: needs_reviewneeds_revision

I've left comments on https://github.com/torproject/tor/pull/1731 .

As for backporting, I agree with backporting the travis changes, but: let's try them in master for a week or so before we backport, in case they turn out to have unforseen drawbacks.

comment:7 Changed 9 months ago by teor

Status: needs_revisionneeds_review

Thanks, I've quoted those variables, improved make's output, and improved the job display on Travis.

comment:8 Changed 9 months ago by teor

Actual Points: 0.60.7

comment:9 Changed 9 months ago by teor

I just compared master and this PR:

Both finish in about 18 minutes, the IPv6-only tests take 12 minutes on macOS.

I think that's a win, because we:

  • added a slow chutney job (25-45 minutes), but made it faster (13 minutes), and
  • deleted a redundant distcheck job (8 minutes),

but kept the same CI wall clock run time.

(The extra 5 minutes for the chutney job is hidden by the parallelism.)

comment:10 Changed 8 months ago by nickm

Status: needs_reviewmerge_ready

LGTM. Let's merge this in into master and let it cook for a little while.

comment:11 Changed 8 months ago by teor

Keywords: consider-backport-after-0433 added; consider-backport-immediately removed
Milestone: Tor: 0.4.4.x-finalTor: 0.4.3.x-final

Merged to master, because I needed it for #33334.

I had to re-do the #33280 and #33195 merge, because the "ours" merge deleted some commits that were merged into 0.4.3 after the branches split off from master.

comment:12 Changed 8 months ago by teor

Keywords: consider-backport-immediately added; consider-backport-after-0433 removed
Milestone: Tor: 0.4.3.x-finalTor: 0.3.5.x-final
Resolution: fixed
Status: merge_readyclosed

Merged to 0.3.5 and later, because I need it for #33048.

We also want to have consistent tor-chutney CI, particularly now that #33232 is merged.

comment:13 Changed 7 months ago by gaba

Keywords: network-team-roadmap-2020Q1 added

Add all the tickets from sponsor 55 that are done and being worked on to the keyword #network-team-roadmap-2020Q1 so I can look at them in the wiki page...

Note: See TracTickets for help on using tickets.