Opened 2 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#33212 closed defect (fixed)

Warning in protover.rs making CI fail.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-backport 041-backport 042-backport 043-should tor-ci
Cc: Actual Points:
Parent ID: Points: .1
Reviewer: ahf Sponsor:

Description

It looks like a new version of Rust is warning about extraneous parentheses, causing our CI to fail in some cases. Let's fix that.

(This is possibly a duplicate, but I can't find the original.)

Child Tickets

Change History (5)

comment:1 Changed 2 weeks ago by nickm

Keywords: 043-should tor-ci added

See branch bug33212_035 with PR at https://github.com/torproject/tor/pull/1713

comment:2 Changed 2 weeks ago by nickm

Status: assignedneeds_review

comment:3 Changed 2 weeks ago by ahf

Reviewer: ahf
Status: needs_reviewmerge_ready

Looks good iff CI gets happy.

comment:4 Changed 2 weeks ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.3.5.x-final
Resolution: fixed
Status: merge_readyclosed

CI is happy. I'm merging this to 0.3.5 and forward so that we have working CI across our branches, and because the fix is trivial.

Note: See TracTickets for help on using tickets.