Opened 8 months ago

Closed 8 months ago

#33306 closed enhancement (fixed)

Consider mapping snowflake locales as we map the tor button and others

Reported by: emmapeel Owned by: cohosh
Priority: Medium Milestone:
Component: Community/Translations Version:
Severity: Normal Keywords: snowflake, l10n
Cc: ggus, cohosh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The Tor Browser is based on Firefox ESR, and so it must use the locale mapping of firefox. But transifex mapping differs a bit. So we map this changes from transifex:

bn = bn-BD
en_GB = en-GB
en = en-US
es_AR = es-AR
es_CL = es-CL
es_CO = es-CO
es = es-ES
es_MX = es-MX
fy = fy-NL
ga = ga-IE
gu = gu-IN
hi = hi-IN
hr_HR = hr-HR
hy = hy-AM
ms_MY = ms
nb = nb-NO
nn = nn-NO
nl_BE = nl-BE
pa = pa-IN
pt_BR = pt-BR
pt_PT = pt-PT
si_LK = si
sv = sv-SE
zh_CN = zh-CN
zh_HK = zh-HK
zh_TW = zh-TW

maybe Snowflake should be mapped with the same locales?

Child Tickets

Change History (8)

comment:1 Changed 8 months ago by emmapeel

Keywords: snowflake added; snoflake removed

comment:2 Changed 8 months ago by emmapeel

Owner: changed from emmapeel to cohosh

comment:3 Changed 8 months ago by cohosh

sounds good to me :)

comment:4 Changed 8 months ago by cohosh

Cc: cohosh added

comment:5 Changed 8 months ago by cohosh

Hey, I'm doing some digging and mozilla actually requires the webextension locales to use the underscore naming convention: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization#Providing_localized_strings_in__locales

It would be a lot easier for webextension packaging purposes to stick with the old way of doing this.

comment:6 Changed 8 months ago by emmapeel

I see. That is funny, as for the Browser they like the hyphen. I have mantained the differences on country code, but I have changed the - to _ now.

Do you think that is OK? See some of the changes at

https://gitweb.torproject.org/translation.git/commit/?h=snowflakeaddon-messages.json&id=b90d8e9e5391f3a3aaa9b9e9707103e9442c0d17

comment:7 Changed 8 months ago by cohosh

Thanks emmapeel! This looks good to me :)

comment:8 Changed 8 months ago by emmapeel

Resolution: fixed
Status: assignedclosed

lovely then! poof! gone!

Note: See TracTickets for help on using tickets.