Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#3332 closed enhancement (fixed)

Assert that HS-related operations are not performed using single-hop circuits

Reported by: rransom Owned by: rransom
Priority: High Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-hs
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When I tested my initial try at implementing #2553, an assertion failed when Tor tried to attach a stream to a single-hop circuit, and appropriately so -- that is almost always a Bad Thing for Tor to do.

But the fact that Tor got that far means that Tor doesn't assert that HS-related directory operations, introduction-point operations, and rendezvous-point operations are not performed over single-hop circuits. It probably should.

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by rransom

Status: newneeds_review

See bug3332 ( git://git.torproject.org/rransom/tor.git bug3332 ).

comment:2 Changed 8 years ago by nickm

I ran into some build issues because build_state is a field in origin_circuit_t, not in circuit_t. Added a fixup commit in branch bug3332 in my public. If you like it, I'll squash and merge into 0.2.3.

comment:3 in reply to:  2 Changed 8 years ago by rransom

Replying to nickm:

I ran into some build issues because build_state is a field in origin_circuit_t, not in circuit_t.

Oops.

Added a fixup commit in branch bug3332 in my public. If you like it, I'll squash and merge into 0.2.3.

It looks good. Thanks!

I needed to rebase my revised branch for #2553 on top of this one, so I've squashed it already -- see bug3332-v2 ( git://git.torproject.org/rransom/tor.git bug3332-v2 ).

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks good -- merged it

comment:5 Changed 6 years ago by nickm

Keywords: tor-hs added

comment:6 Changed 6 years ago by nickm

Component: Tor Hidden ServicesTor
Note: See TracTickets for help on using tickets.