Opened 5 days ago

Closed 3 hours ago

#33334 closed enhancement (fixed)

Add a mixed+hs-v23-ipv6 network to tor's test-network

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, prop311
Cc: teor Actual Points: 0.3
Parent ID: #33050 Points: 0.2
Reviewer: nickm Sponsor: Sponsor55-must

Description

We want to add the new mixed+hs-v23-ipv6 chutney network from #33333 to tor's makefile tests:

  • test-network-all
  • test-network-ipv6

We'll need some minor refactoring, so that we can test for "ipv6" and "mixed", before using this network.

I think the resulting code will be simpler.

We can pass the following network lists to the test-network-run target:

  • unconditional (ipv4 and not mixed)
  • ipv6
  • mixed
  • mixed_ipv6

Then we can:

  • test for ipv6 and mixed in separate tests,
  • set flags for mixed and ipv6, and
  • skip or use the right network lists.

Child Tickets

Change History (6)

comment:1 Changed 2 days ago by teor

Actual Points: 0.3
Reviewer: nickm
Status: assignedneeds_review

comment:2 Changed 2 days ago by teor

Parent ID: #33232#33050

comment:3 Changed 24 hours ago by teor

Looks like Travis passed here, but the CI is still shown as pending.

comment:4 Changed 13 hours ago by nickm

Status: needs_reviewmerge_ready

This looks okay to me. It's possible that there are bugs in the makefile rewriting, but I didn't find any.

comment:5 Changed 4 hours ago by teor

I tweaked the list of IPv4 chutney networks slightly, for consistency, and to remove duplication.

I also made sure that chutney uses the same networks in its CI, in #33376.

I'll merge to master as soon as CI passes, because I need these changes in CI for #33232 (chutney reachability checks).

comment:6 Changed 3 hours ago by teor

Resolution: fixed
Status: merge_readyclosed

Merged to master.

Note: See TracTickets for help on using tickets.