Small changes to scheduler comments and state changes

I have attached a patch that tries to make some of the comments in scheduler.c easier to follow, such as the comments that reference the old channels_waiting_for_cells and channels_waiting_to_write lists that were removed in commit 3530825c5. It also simplifies a couple of the channel state changes.

changed milestone to %Tor: 0.4.4.x-final

added component::core tor/tor milestone::Tor: 0.4.4.x-final priority::medium resolution::fixed reviewer::dgoulet severity::normal status::closed tor-sched type::enhancement labels

Trac:
ticket33349.patch

Trac:
addendum-1.patch

We'll need a PR so our CI runs it because there are code changes.

@opara, if you can't provide one (via Github for now), let me know, I'll create a branch with your patch for it.

Trac:
Milestone: N/A to Tor: 0.4.4.x-final
Status: new to needs_review
Keywords: N/A deleted, tor-sched added
Reviewer: N/A to dgoulet

Sure I've added one here: https://github.com/torproject/tor/pull/1746

Looks like CI failed, let us know if you need help fixing the issues.

Trac:
Status: needs_review to needs_revision

It seems to be upset about the changes/ticket33349 file using the header "Code simplifications and refactoring", which your doc/HACKING/CodingStandards.md documentation says I should use.

Oops forgot to include the error:

./changes/ticket33349:

	Unrecognized header: 'Code simplifications and refactoring'

make[1]: *** [check-changes] Error 1

Apparently the lintChanges script only accepts "Code simplification and refactoring" [with no s at the end of "simplification"]. I'll edit the script to be a bit more tolerant, since the sortChanges.py script knows how to clean that one up.

lgtm!

@opara, I've put in a comment in the PR, doesn't stop the merge of this patch but I would love it if you could confirm what I said there? Thanks!

(I'll merge once I get a ACK from opara).

Trac:
Status: needs_revision to merge_ready

Thanks, if you'd like I can update the header to remove the extra 's'. And @dgoulet I added a reply to the PR, if there's any way I can improve the code comment that you commented on let me know. I don't want to change anything while this ticket is in the 'merge_ready' state, but I can still change something if anyone would like.

Replying to opara:

Thanks, if you'd like I can update the header to remove the extra 's'. And @dgoulet I added a reply to the PR, if there's any way I can improve the code comment that you commented on let me know. I don't want to change anything while this ticket is in the 'merge_ready' state, but I can still change something if anyone would like.

Nice thanks! And yes, just push a fixup commit for the removal of 's' and we'll be on our way to merge this.

Thanks!

Replying to dgoulet:

Nice thanks! And yes, just push a fixup commit for the removal of 's' and we'll be on our way to merge this.

I posted a fixup commit, but I'm not sure if you want me to squash it as well (or if you do that yourself so that you can audit changes better). If you want me to squash them let me know.

Merged thanks!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved to tpo/core/tor#33349 (closed)