Split chutney's diagnostics into a new script

Chutney's failure diagnostics are currently in the Travis CI config file.

But we want to use them in tor's CI. And maybe chutney users want to use them as well.

Trac:
Parent Ticket: #33050 (moved)

added 044-should actualpoints::0.2 chutney component::core tor/chutney network-team-roadmap-2020Q1 owner::teor parent::33050 points::0.2 priority::medium resolution::fixed reviewer::nickm severity::normal sponsor::55-must status::closed tor-ci type::task labels

See my PR:

• chutney: https://github.com/torproject/chutney/pull/54

I'd like to merge this change after CI passes, because I need it in chutney master for tor's #32792 (moved). But I'd still like a review.

Trac:
Parent: #32792 (moved) to #33050 (moved)
Reviewer: N/A to nickm
Status: assigned to needs_review

I also added a pre-commit hook to chutney, and added that pre-commit hook to the shellcheck tests.

Looks mostly okay to me. I've added a couple of shell questions, but if I'm wrong about my shell usage, feel free to call this merge ready and merge it.

Trac:
Status: needs_review to needs_revision

I think the shell script syntax is ok. Shellcheck doesn't complain, and we do the same thing in test-network.sh.

Merged to master.

Trac:
Resolution: N/A to fixed
Status: needs_revision to closed

Add all the tickets from sponsor 55 that are done and being worked on to the keyword #network-team-roadmap-2020Q1 so I can look at them in the wiki page...

Trac:
Keywords: N/A deleted, network-team-roadmap-2020Q1 added

closed

changed time estimate to 1h 36m

added 1h 36m of time spent

mentioned in issue #33050 (moved)

moved to tpo/core/chutney#33353 (closed)