Opened 8 months ago

Closed 8 months ago

Last modified 7 months ago

#33353 closed task (fixed)

Split chutney's diagnostics into a new script

Reported by: teor Owned by: teor
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: 044-should, tor-ci, chutney, network-team-roadmap-2020Q1
Cc: teor Actual Points: 0.2
Parent ID: #33050 Points: 0.2
Reviewer: nickm Sponsor: Sponsor55-must

Description

Chutney's failure diagnostics are currently in the Travis CI config file.

But we want to use them in tor's CI. And maybe chutney users want to use them as well.

Child Tickets

Change History (5)

comment:1 Changed 8 months ago by teor

Parent ID: #32792#33050
Reviewer: nickm
Status: assignedneeds_review

See my PR:

I'd like to merge this change after CI passes, because I need it in chutney master for tor's #32792. But I'd still like a review.

comment:2 Changed 8 months ago by teor

I also added a pre-commit hook to chutney, and added that pre-commit hook to the shellcheck tests.

comment:3 Changed 8 months ago by nickm

Status: needs_reviewneeds_revision

Looks mostly okay to me. I've added a couple of shell questions, but if I'm wrong about my shell usage, feel free to call this merge ready and merge it.

comment:4 Changed 8 months ago by teor

Resolution: fixed
Status: needs_revisionclosed

I think the shell script syntax is ok.
Shellcheck doesn't complain, and we do the same thing in test-network.sh.

Merged to master.

comment:5 Changed 7 months ago by gaba

Keywords: network-team-roadmap-2020Q1 added

Add all the tickets from sponsor 55 that are done and being worked on to the keyword #network-team-roadmap-2020Q1 so I can look at them in the wiki page...

Note: See TracTickets for help on using tickets.