Don't compile ext_orport.c when relay mode is disabled.

changed milestone to %Tor: 0.4.4.x-final

Trac:
Parent Ticket: #31851 (moved)

added 043-deferred actualpoints::.1 component::core tor/tor library-size milestone::Tor: 0.4.4.x-final network-team-roadmap-2020Q1 owner::nickm parent::31851 priority::medium resolution::implemented reviewer::ahf severity::normal status::closed tor-design type::defect labels

Branch is extract_ext_orport with PR at https://github.com/torproject/tor/pull/1753

Trac:
Keywords: 043-deferred deleted, 043-deferred library-size added
Status: assigned to needs_review

Looks good, but pending CI.

Trac:
Reviewer: N/A to ahf
Status: needs_review to merge_ready

Looks like src/feature/client/transports.c has some relay code. I added it to the end of phase 2 in: https://trac.torproject.org/projects/tor/ticket/31851#comment:10

The following functions don't have stub implementations:

• connection_or_get_by_ext_or_id
• init_ext_or_cookie_authentication
• ext_orport_free_all

Do they belong in the implementation file, rather than the header?

Or can they have a header comment, explaining why there's no stub?

Trac:
Status: merge_ready to needs_revision

(Feel free to merge_ready or merge once these minor issues are fixed.)

Thanks for the review! I've added comments and moved functions per your comment above; once CI has passed, I'll merge.

I've also opened #33383 (moved) because of my surprise about an unused function.

CI has passed; merging this.

Trac:
Resolution: N/A to implemented
Status: needs_revision to closed

closed

added 48m of time spent

mentioned in issue #33383 (moved)

mentioned in issue #31851 (moved)

moved to tpo/core/tor#33368 (closed)

mentioned in issue tpo/core/tor#33383 (closed)