Opened 7 years ago

Closed 6 years ago

#3337 closed defect (fixed)

Torbutton should fetch a version list from check.tp.o

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone: TorBrowserBundle 2.2.x-stable
Component: TorBrowserButton Version:
Severity: Keywords: MikePerryIteration20110911
Cc: Actual Points: 2
Parent ID: Points: 3
Reviewer: Sponsor:

Description

We hacked check.tp.o to return a minimal XHTML response to https://check.torproject.org/?TorButton=true.

We should create a new parameter that returns a version list of recommended Tor Browser Bundle versions at a url like https://check.torproject.org/?ReportVersions=true

Torbutton should check to see if the current TBB version is in this list and if is not, it should use a yellow-themed version of check.torproject.org that recommends that the user upgrades.

Child Tickets

Change History (7)

comment:1 Changed 7 years ago by mikeperry

#2285 is the check bug for this. #2338 is another torbutton bug we can knock out with this same logic.

comment:2 Changed 6 years ago by mikeperry

Milestone: TorBrowserBundle 2.2.x-stable
Status: newaccepted

comment:3 Changed 6 years ago by mikeperry

Note to self: Torbutton also needs to do an XMLHTTPRequest of this page if the user has changed their TBB homepage to something other than check.

comment:4 Changed 6 years ago by mikeperry

Points: 5

comment:5 Changed 6 years ago by mikeperry

Keywords: MikePerryIteration20110911 added
Points: 52

I can probably implement this without check using an alternate test url. Also, 5 points is a bit much.

comment:6 Changed 6 years ago by mikeperry

Points: 23

Forgot about the homepage juggling piece. Can leverage #2338 for that, but who knows what might break...

comment:7 Changed 6 years ago by mikeperry

Actual Points: 2
Resolution: fixed
Status: acceptedclosed

Uses https://check.torproject.org/RecommendedTBBVersions as the version list. If this url is 404, the feature is disabled. Otherwise, we check to see if the current value of torbrowser.version is present in the returned JSON list. If so, we fetch the normal check homepage. Otherwise, we fetch the upgrade notice.

Will update #2285 for more detailed instructions for check.

Note: See TracTickets for help on using tickets.