Opened 5 weeks ago

Closed 5 weeks ago

#33385 closed enhancement (fixed)

In server, treat a purported client IP address of 0.0.0.0 as missing

Reported by: dcf Owned by: dcf
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords:
Cc: cohosh, phw, arlolra, dcf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #33157, proxies sometimes fail to extract a meaningful client IP address from the client's SDP and send ?client_ip=0.0.0.0 to the bridge. The bridge counts an address of 0.0.0.0 as a client that had an IP address, which inflates the numerator in the in the past %.f s, %d/%d connections had client_ip log line.

This is a patch to treat a client address of 0.0.0.0 or [::] as if it were not present at all.

Child Tickets

Attachments (1)

0001-In-server-treat-a-client-IP-address-of-0.0.0.0-as-mi.patch (1.5 KB) - added by dcf 5 weeks ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 5 weeks ago by dcf

Status: assignedneeds_review

comment:2 Changed 5 weeks ago by cohosh

Status: needs_reviewmerge_ready

Looks good to me.

comment:3 Changed 5 weeks ago by dcf

Resolution: fixed
Status: merge_readyclosed

Merged in c124e8c643f2de5730af9079d326b9cabc3b264a.

I also merged it into the turbotunnel branch at 924593615c5a8fca7e0d9b4c0fafbd143db1bb62, because that branch is what's currently deployed (#33336) and I want to add an entry to MetricsTimeline marking when this client_ip change took effect. I'm afraid that if I only make the change in a branch that's not currently deployed, we will forget to mark the date when we do eventually move back to that branch. I built commit 47312dd1eccc8456652853bd66f8ed396e9ba6ec and deployed it at 2020-02-22 23:51:15.

Note: See TracTickets for help on using tickets.