Disable routerkeys.c and part of connection_or.c when building without relay mode.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Nick Mathewson changed milestone to %Tor: 0.4.4.x-final
changed milestone to %Tor: 0.4.4.x-final
Trac:
Parent Ticket: #31851 (moved)- Author
Branch is
extract_routerkeys
with PR at https://github.com/torproject/tor/pull/1758Adding teor to cc, but review on this one isn't so urgent.
Trac:
Cc: nickm to teor - Author
Trac:
Status: assigned to needs_review CI seems to have failed on --disable-module-relay.
I see a significant number of linker errors here:
Trac:
Status: needs_review to needs_revision- Author
D'oh. Looks like router.c still needed a bunch of the functions I had removed in the last commit. It seems they got optimized away in my regular build. Removing the last commit and pushing again.
- Author
...and fixing that turned up another bug. Pushed a fixup, trying again...
- Author
Okay. Travis is passing now.
Trac:
Status: needs_revision to needs_review - Developer
This looks good! Is there a ticket for the second half of this where the router code is removed?
Trac:
Status: needs_review to merge_ready - Author
Is there a ticket for the second half of this where the router code is removed?
Not yet, but I hope to get to that later today or next week.
- Developer
Cool!
Trac:
Reviewer: N/A to ahf - Author
squashed and merged this!
Trac:
Status: merge_ready to closed
Resolution: N/A to implemented - Trac closed
closed
- Trac added 1h 36m of time spent
added 1h 36m of time spent
- Trac mentioned in issue #31851 (moved)
mentioned in issue #31851 (moved)
- Trac moved to tpo/core/tor#33389 (closed)
moved to tpo/core/tor#33389 (closed)