Remove all non-dirauth usage of dirauth timing options.

There's code in shared_random_client.c that uses dirauth-only options, directly or indirectly. It shouldn't, since clients should only be looking at the consensus to learn what the vote schedule is.

changed milestone to %Tor: 0.4.4.x-final

Trac:
Parent Ticket: #32810 (moved)

added component::core tor/tor milestone::Tor: 0.4.4.x-final owner::nickm parent::32810 points::.5 priority::medium resolution::fixed reviewer::asn severity::normal status::closed technical-debt type::defect labels

Code in ticket33436, with PR at https://github.com/torproject/tor/pull/1763 .

I'd like to know what asn and dgoulet think of this; I hope that some approach like this will work, but it might need changes.

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to asn

This is nice! Did a review as well!

Trac:
Status: needs_review to needs_revision

I've added comments to the code and asked some questions on the review.

I've made the requested changes.

Trac:
Status: needs_revision to needs_review

Looks really good!

Merged after fixing the following trivial comment:

     /* We should never be reaching this point, since a client should never
-     * call this code unless they have some kidn of a consensus. All we can
+     * call this code unless they have some kind of a consensus. All we can
      * do is hope that this network is using the default voting interval. */

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

changed time estimate to 4h

mentioned in issue #32810 (moved)

moved to tpo/core/tor#33436 (closed)