Opened 4 months ago

Closed 6 weeks ago

#33458 closed defect (fixed)

Assertion desc failed in hs_client_close_intro_circuits_from_desc at src/feature/hs/hs_client.c: 2413

Reported by: asn Owned by: dgoulet
Priority: High Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs client-auth assert 043-must
Cc: Actual Points: 0.3
Parent ID: Points:
Reviewer: asn Sponsor:

Description

Just got this assert failure in my TBB. I had a v3 onion open, and long ago I visited a client-auth onion that I didn't manage to decrypt so it lingered in my cache with ->desc set to NULL.

Feb 26 14:17:31.000 [err] tor_assertion_failed_(): Bug: src/feature/hs/hs_client.c:2413: hs_client_close_intro_circuits_from_desc: Assertion desc failed; aborting. (on T
or 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug: Tor 0.4.3.2-alpha (git-dcbf6611d9980953): Assertion desc failed in hs_client_close_intro_circuits_from_desc at src/feature/hs/hs_client.c:
2413: . Stack trace: (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(log_backtrace_impl+0x56) [0x5623c8fe6e96] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_assertion_failed_+0x147) [0x5623c8fe1f97] (on Tor 0.4.3.2-alpha dcbf6611d9980
953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(hs_client_close_intro_circuits_from_desc+0xb6) [0x5623c8ee7c76] (on Tor 0.4.3.2-a
lpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(hs_cache_clean_as_client+0xf2) [0x5623c8edfbd2] (on Tor 0.4.3.2-alpha dcbf6611d99
80953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x6ebbc) [0x5623c8e3fbbc] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x73487) [0x5623c8e44487] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     ./TorBrowser/Tor/libevent-2.1.so.6(+0x22565) [0x7f3c28b8a565] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     ./TorBrowser/Tor/libevent-2.1.so.6(event_base_loop+0x517) [0x7f3c28b8af27] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(do_main_loop+0xdb) [0x5623c8e4372b] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_run_main+0x10b5) [0x5623c8e309f5] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_main+0x3a) [0x5623c8e2e19a] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(main+0x19) [0x5623c8e2dd39] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7f3c28207bbb] (on Tor 0.4.3.2-alpha dcbf6611d9980953)
Feb 26 14:17:31.000 [err] Bug:     /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x5cd89) [0x5623c8e2dd89] (on Tor 0.4.3.2-alpha dcbf6611d9980953)

Child Tickets

Change History (12)

comment:1 Changed 4 months ago by nickm

Keywords: 043-must added
Priority: MediumHigh

comment:2 Changed 4 months ago by dgoulet

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final
Owner: set to dgoulet
Reviewer: asn
Status: newaccepted

comment:3 Changed 4 months ago by dgoulet

Status: acceptedneeds_review

0.4.3 PR: https://github.com/torproject/tor/pull/1782

The 044 PR has much more code in order to create a proper interface to access the decrypted descriptor in the cache.

0.4.4 PR: https://github.com/torproject/tor/pull/1783

comment:4 Changed 4 months ago by asn

Status: needs_reviewneeds_revision

Did review! :)

comment:5 Changed 4 months ago by dgoulet

Status: needs_revisionneeds_review

Ok back in your court (both branches). Unit test + a fix discussed on IRC in the fixup.

comment:6 Changed 4 months ago by dgoulet

As discussed on IRC, since 044 branch turned out to not be complicated, here is the whole thing on 043:

Branch: ticket33458_043_02
PR: https://github.com/torproject/tor/pull/1792

comment:7 Changed 4 months ago by asn

Status: needs_reviewneeds_revision

Ugh one final thing. This is missing a changes file!

comment:8 Changed 4 months ago by dgoulet

Status: needs_revisionneeds_review

Pushed.

comment:9 Changed 4 months ago by asn

Resolution: fixed
Status: needs_reviewclosed

Merged! Thanks!

comment:10 Changed 6 weeks ago by ggus

I'm using Tor Browser Alpha 9.5a13 and had the same issue described by asn.

5/26/20, 13:47:12.879 [ERR] tor_assertion_failed_(): Bug: src/feature/hs/hs_client.c:2425: hs_client_close_intro_circuits_from_desc: Assertion desc failed; aborting. (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.887 [ERR] Bug: Tor 0.4.3.5 (git-5ceb60e5ca61fec9): Assertion desc failed in hs_client_close_intro_circuits_from_desc at src/feature/hs/hs_client.c:2425: . Stack trace: (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.888 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(log_backtrace_impl+0x56) [0x60371af34cb6] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.888 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_assertion_failed_+0x147) [0x60371af2fdb7] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.888 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(hs_client_close_intro_circuits_from_desc+0xb6) [0x60371ae43356] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.888 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(hs_cache_clean_as_client+0xf2) [0x60371ae3b2a2] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.888 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x6f04c) [0x60371ad8d04c] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.888 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x73917) [0x60371ad91917] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.888 [ERR] Bug:     ./TorBrowser/Tor/libevent-2.1.so.7(+0x227f2) [0x77a342c1f7f2] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.888 [ERR] Bug:     ./TorBrowser/Tor/libevent-2.1.so.7(event_base_loop+0x517) [0x77a342c20067] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.889 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(do_main_loop+0xdb) [0x60371ad90bbb] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.889 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_run_main+0x10b5) [0x60371ad7dea5] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.890 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_main+0x3a) [0x60371ad7b64a] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.890 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(main+0x19) [0x60371ad7b1e9] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.890 [ERR] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x77a34229409b] (on Tor 0.4.3.5 5ceb60e5ca61fec9)
5/26/20, 13:47:12.890 [ERR] Bug:     /home/user/Downloads/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x5d239) [0x60371ad7b239] (on Tor 0.4.3.5 5ceb60e5ca61fec9)

comment:11 Changed 6 weeks ago by asn

Resolution: fixed
Status: closedreopened

Hm, perhaps that was not merged to 043.

comment:12 Changed 6 weeks ago by asn

Resolution: fixed
Status: reopenedclosed

Merged to 043 as well. After the next 043 release, this should not be a problem anymore.

Note: See TracTickets for help on using tickets.