confmgt: include variable name in all complaints.

When we give a msg about failing to parse a variable, we should say what the variable was, and ideally what was wrong with it.

Compare the results for running ./src/app/tor UseBridges 99 in 0.3.5 and in master. With 0.3.5 you got: Boolean 'UseBridges 99' expects 0 or 1. but now you get Unrecognized value 99.

Let's make that better.

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #33014 (moved)

added 043-backport 043-may?? actualpoints::.1 component::core tor/tor milestone::Tor: 0.4.3.x-final owner::nickm parent::33014 points::.1 priority::medium resolution::implemented reviewer::catalyst severity::normal status::closed type::enhancement ui ui-regression ux labels

This is needed to avoid a usability regression on #33014 (moved).

Trac:
Parent: N/A to #33014 (moved)

Trac:
Actualpoints: N/A to .1
Milestone: Tor: 0.4.3.x-final to Tor: 0.4.4.x-final
Keywords: ui-regression 043-may?? deleted, ui-regression 043-may?? 043-backport added

See branch ticket33460_043 with PR at https://github.com/torproject/tor/pull/1765 .

The new error message for the case in the ticket description is Could not parse UseBridges: Unrecognized value 99. Allowed values are 0 and 1.

This branch is against 0.4.3 but merges cleanly to master.

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to catalyst

Replying to nickm:

See branch ticket33460_043 with PR at https://github.com/torproject/tor/pull/1765 .

The new error message for the case in the ticket description is Could not parse UseBridges: Unrecognized value 99. Allowed values are 0 and 1.

This branch is against 0.4.3 but merges cleanly to master. The pull request is against master. I'm not sure there's been enough divergence for it to cause problems, though.

I made a small comment on the pull request about appearing to work around a design limitation in the existing code. I think we don't need to address it right now, but I wanted to make a note of it in case it requires related workarounds in the future.

Trac:
Status: needs_review to merge_ready

Thanks for the review; merged this to 0.4.3 and forward.

I agree with you about the design limitation.

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

Trac:
Milestone: Tor: 0.4.4.x-final to Tor: 0.4.3.x-final

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #33014 (moved)

moved to tpo/core/tor#33460 (closed)