Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#33460 closed enhancement (implemented)

confmgt: include variable name in all complaints.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ui, ux, ui-regression 043-may?? 043-backport
Cc: Actual Points: .1
Parent ID: #33014 Points: .1
Reviewer: catalyst Sponsor:

Description

When we give a msg about failing to parse a variable, we should say what the variable was, and ideally what was wrong with it.

Compare the results for running ./src/app/tor UseBridges 99 in 0.3.5 and in master. With 0.3.5 you got: Boolean 'UseBridges 99' expects 0 or 1. but now you get Unrecognized value 99.

Let's make that better.

Child Tickets

Change History (7)

comment:1 Changed 5 months ago by nickm

Parent ID: #33014

This is needed to avoid a usability regression on #33014.

comment:2 Changed 5 months ago by nickm

Actual Points: .1
Keywords: 043-backport added
Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

comment:3 Changed 5 months ago by nickm

Status: assignedneeds_review

See branch ticket33460_043 with PR at https://github.com/torproject/tor/pull/1765 .

The new error message for the case in the ticket description is Could not parse UseBridges: Unrecognized value 99. Allowed values are 0 and 1.

This branch is against 0.4.3 but merges cleanly to master.

comment:4 Changed 5 months ago by dgoulet

Reviewer: catalyst

comment:5 in reply to:  3 Changed 5 months ago by catalyst

Status: needs_reviewmerge_ready

Replying to nickm:

See branch ticket33460_043 with PR at https://github.com/torproject/tor/pull/1765 .

The new error message for the case in the ticket description is Could not parse UseBridges: Unrecognized value 99. Allowed values are 0 and 1.

This branch is against 0.4.3 but merges cleanly to master.

The pull request is against master. I'm not sure there's been enough divergence for it to cause problems, though.

I made a small comment on the pull request about appearing to work around a design limitation in the existing code. I think we don't need to address it right now, but I wanted to make a note of it in case it requires related workarounds in the future.

comment:6 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Thanks for the review; merged this to 0.4.3 and forward.

I agree with you about the design limitation.

comment:7 Changed 5 months ago by teor

Milestone: Tor: 0.4.4.x-finalTor: 0.4.3.x-final
Note: See TracTickets for help on using tickets.