Opened 8 months ago

Closed 5 months ago

#33514 closed defect (fixed)

non-en-US Tor Browser 9.5a6 won't start up

Reported by: mcs Owned by: sysrqb
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A user on the #tor IRC channel experienced an error after their browser updated (presumably to 9.5a6). The error is in Turkish, but it appears to be a undefined entity error in browser.xul that is related to the #19757 patches.

I confirmed that a browser window fails to open (and the browser exits) when I use clean installs of both es-ES and tr packages on macOS.

My best guess is that translations were not updated in Torbutton prior to this Tor Browser release, but I have not confirmed that yet.

Child Tickets

Change History (6)

comment:1 Changed 8 months ago by mcs

I confirmed that the entity torbutton.onionServices.authPrompt.persistCheckboxLabel is only defined in chrome/locale/en-US/torbutton.dtd and not in the other torbutton.dtd files.

comment:2 Changed 8 months ago by sysrqb

Yeah. The lack of localized strings is expected, but the crashing is not. I guess I misunderstood the process for landing new strings. As I said in ticket:19757#comment:47, I thought this would only result in English strings being available, but I should've realized that the browser wouldn't fallback on English strings if the entity is not defined in the locale's dtd file.

comment:3 Changed 8 months ago by sysrqb

Owner: changed from tbb-team to sysrqb
Status: newaccepted

As an update, we're building 9.5a7 which should fix this.

comment:4 Changed 8 months ago by mcs

For non-en-US users who already updated to 9.5a6, using a text editor to add the following line to prefs.js allows the browser to start up correctly:

user_pref("intl.locale.requested", "en-US");

(tested on macOS, but should work on all of our desktop platforms). This will allow people to update to 9.5a7, after which they can remove that line from their prefs.js and go back to enjoying Tor Browser in their favorite language.

comment:5 in reply to:  4 Changed 8 months ago by sysrqb

Replying to mcs:

For non-en-US users who already updated to 9.5a6, using a text editor to add the following line to prefs.js allows the browser to start up correctly:

user_pref("intl.locale.requested", "en-US");

(tested on macOS, but should work on all of our desktop platforms). This will allow people to update to 9.5a7, after which they can remove that line from their prefs.js and go back to enjoying Tor Browser in their favorite language.

Oh, that's smart. Thanks!

For clarify, the error causing this is:

Error de lectura XML: entidad no definida
Ubicación: chrome://browser/content/browser.xul
Número de línea 3173, columna 7:

      <checkbox id="tor-clientauth-persistkey-checkbox"
------^

comment:6 Changed 5 months ago by sysrqb

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.