Opened 5 months ago

Last modified 8 weeks ago

#33559 merge_ready defect

Update tor-android-service To Use Updated Android Toolchain

Reported by: sisbell Owned by: gk
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202006R, gitlab-tb-tor-browser-build
Cc: tbb-team, sysrqb, boklm Actual Points: .5
Parent ID: #33184 Points:
Reviewer: sysrqb, ahf Sponsor: Sponsor58-must

Description

We need to upgrade android toolchain to support fenix. This requires update to tor-android-service.

Child Tickets

Change History (13)

comment:1 Changed 5 months ago by pili

Sponsor: Sponsor58-must

Adding sponsor to tickets

comment:2 Changed 4 months ago by sisbell

Actual Points: .5
Cc: eighthave removed

Upgraded tor-android-service to use new gradle and android dependencies. tbb tor-android-service projects gradle dependencies and versions.

https://github.com/sisbell/tor-browser-build/commits/bug-33559

https://github.com/sisbell/tor-android-service/commits/bug-33559

comment:3 Changed 4 months ago by sisbell

Status: newneeds_review

comment:4 Changed 4 months ago by gk

Keywords: TorBrowserTeam202004R added

comment:5 Changed 3 months ago by gk

Keywords: tbb-rbm TorBrowserTeam202005R added; Android TorBrowserTeam202004R removed
Reviewer: gk

comment:6 Changed 3 months ago by gk

Priority: MediumHigh

Moving tickets to high prio.

comment:7 Changed 3 months ago by gk

Keywords: TorBrowserTeam202005 GeorgKoppen202005 added; TorBrowserTeam202005R removed
Reviewer: gksysrqb, ahf
Status: needs_reviewneeds_revision

Mozilla still has the minVersion set to 16 (at least for non-64bit targets). We should keep that.

comment:8 Changed 3 months ago by gk

Cc: tbb-team added
Owner: changed from tbb-team to gk
Status: needs_revisionassigned

comment:9 Changed 3 months ago by gk

Keywords: TorBrowserTeam202005R added; TorBrowserTeam202005 removed
Status: assignedneeds_review

bug_33559_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_33559_v2&id=91d98030ede7dbe2b3f38d2eeed97fc70110d15b) contains a patch for review.

The branch contains an additional patch, commit d356f1a34ddf4054b4605bb1f4886bf19dcacb73 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_33559_v2&id=d356f1a34ddf4054b4605bb1f4886bf19dcacb73) which points to my tor-android-service branch (bug_33559) to get things building. That branch (https://gitweb.torproject.org/user/gk/tor-android-service.git/commit/?h=bug_33559&id=80db85213ea4af1a7976531ecbba94e521d6efbd) needs review as well.

I cleaned a bunch of things up while I was at it as it seemed to me those artifacts are not needed anymore. In particular, I got rid off libtun2socks.so which I think we don't need for our use-case.

comment:10 Changed 3 months ago by ahf

Status: needs_reviewmerge_ready

Patches looks good. Hashes at https://anubis.0x90.dk/~ahf/android-tb.txt

comment:11 Changed 2 months ago by gk

Keywords: TorBrowserTeam202006R added; TorBrowserTeam202005R removed

Moving review tickets.

comment:12 in reply to:  10 Changed 8 weeks ago by gk

Replying to ahf:

Patches looks good. Hashes at https://anubis.0x90.dk/~ahf/android-tb.txt

Thanks. I moved forward and rebased + merged the tor-android-service patch to master (commit 8f40b9b2a6f4f8c05b84c5a0fec26a4b7ad77098).

comment:13 Changed 8 weeks ago by gk

Keywords: gitlab-tb-tor-browser-build added

Add magic gitlab keyword.

Note: See TracTickets for help on using tickets.