Opened 7 months ago

Closed 5 months ago

#33562 closed defect (worksforme)

Upgrade libevent to use NDK 20

Reported by: sisbell Owned by: gk
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
Cc: tbb-team Actual Points:
Parent ID: #33184 Points:
Reviewer: sysrqb Sponsor: Sponsor58-must

Description

This is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.

Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locations.

Child Tickets

Change History (9)

comment:1 Changed 7 months ago by eighthave

Cc: eighthave removed

The official NDK binaries have worked directly with autotools, make, etc for several years now. Ditching support for the old "standalone" approach is definitely the right way, and will also work for all the bits that are used in Orbot.

comment:2 Changed 7 months ago by pili

Sponsor: Sponsor58-must

Adding sponsor to tickets

comment:3 Changed 5 months ago by pili

I read in the last meeting notes that this issue was complete? Should we move it to needs_review?

comment:4 Changed 5 months ago by gk

Cc: tbb-team added; sysrqb boklm removed
Keywords: tbb-rbm TorBrowserTeam202005 GeorgKoppen202005 added; Android removed
Owner: changed from tbb-team to gk
Reviewer: sysrqb
Status: newassigned

comment:5 Changed 5 months ago by gk

Priority: MediumHigh

Moving tickets to high prio.

comment:6 in reply to:  3 Changed 5 months ago by gk

Resolution: worksforme
Status: assignedclosed

Replying to pili:

I read in the last meeting notes that this issue was complete? Should we move it to needs_review?

Not sure what that means but it's building without any changes. Thus, closing as WORKSFORME.

comment:7 Changed 5 months ago by gk

Resolution: worksforme
Status: closedreopened

The build does not produce object files in the right format, though, even though it is not breaking directly, reopening.

comment:8 Changed 5 months ago by gk

Summary: Upgrade libevent to use NDK 21Upgrade libevent to use NDK 20

comment:9 Changed 5 months ago by gk

Resolution: worksforme
Status: reopenedclosed

Okay, this is actually something that should get addressed in #33760, closing again.

Note: See TracTickets for help on using tickets.