Opened 8 months ago

Last modified 5 months ago

#33564 merge_ready defect

Upgrade ZSTD to use Android NDK 20

Reported by: sisbell Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202006R, gitlab-tb-tor-browser-build
Cc: sysrqb, boklm Actual Points: .1
Parent ID: #33184 Points:
Reviewer: sysrqb, ahf Sponsor: Sponsor58-must

Description

This is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.

Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locations

Child Tickets

Change History (17)

comment:1 Changed 8 months ago by eighthave

Cc: eighthave removed

The official NDK binaries have worked directly with autotools, make, etc for several years now. Ditching support for the old "standalone" approach is definitely the right way, and will also work for all the bits that are used in Orbot.

comment:2 Changed 7 months ago by pili

Sponsor: Sponsor58-must

Adding sponsor to tickets

comment:3 Changed 7 months ago by sisbell

Actual Points: .1
Status: newneeds_review

Latest NDK changes how we specify the target sdk version

https://github.com/sisbell/tor-browser-build/commits/bug-33564

comment:4 Changed 7 months ago by gk

Keywords: TorBrowserTeam202004R added

comment:5 Changed 6 months ago by gk

Keywords: tbb-rbm TorBrowserTeam202005R added; Android TorBrowserTeam202004R removed
Reviewer: gk

comment:6 Changed 6 months ago by gk

Priority: MediumHigh

Moving tickets to high prio.

comment:7 Changed 6 months ago by gk

Looks good to me and works. I've pushed bug_33564 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_33564&id=a772e81b5104e5aa179b62ffceaff3f60ae127b2) with a slightly modified commit message and on top of my fenix_toolchain branch.

comment:8 Changed 6 months ago by gk

Status: needs_reviewmerge_ready

comment:9 Changed 6 months ago by gk

Keywords: TorBrowserTeam202005 GeorgKoppen202005 added; TorBrowserTeam202005R removed
Status: merge_readyneeds_revision

While this works we can do slightly better by using var/CC.

comment:10 Changed 6 months ago by gk

Keywords: TorBrowserTeam202005R added; TorBrowserTeam202005 removed
Reviewer: gksysrqb
Status: needs_revisionneeds_review

comment:11 Changed 6 months ago by gk

Summary: Upgrade ZSTD to use Android NDK 21Upgrade ZSTD to use Android NDK 20

comment:13 Changed 5 months ago by ahf

Reviewer: sysrqbsysrqb, ahf

comment:14 Changed 5 months ago by gk

sponsor58-must

comment:15 Changed 5 months ago by ahf

Status: needs_reviewmerge_ready

Looks good and compiles (tested via #33563 v3 branch).

comment:16 Changed 5 months ago by gk

Keywords: TorBrowserTeam202006R added; TorBrowserTeam202005R removed

Moving review tickets.

comment:17 Changed 5 months ago by gk

Keywords: gitlab-tb-tor-browser-build added

Add magic gitlab keyword.

Note: See TracTickets for help on using tickets.