Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#33583 closed enhancement (fixed)

Stop setting AssumeReachable on chutney relays and bridges

Reported by: teor Owned by: teor
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: ipv6, prop311, network-team-roadmap-2020Q1
Cc: teor Actual Points: 0.3
Parent ID: #33050 Points: 0.5
Reviewer: ahf Sponsor: Sponsor55-must

Description

We need to stop setting AssumeReachable on relays and bridges in chutney networks, so they do reachability self-tests.

We should continue to set AssumeReachable on authorities (including the bridge authority), because it disables authority to relay reachability tests. (These tests are still performed on a half-hourly schedule, even in chutney networks. And they are out of scope for Sponsor 55.)

After we implement this change, we should also be able to implement #33581.

Child Tickets

Change History (6)

comment:1 Changed 4 months ago by teor

Actual Points: 0.2
Reviewer: ahf
Status: assignedneeds_review

This is a very small PR on top of #33379.

It moves AssumeReachable 1 from common.i (all nodes) to authority.i (authorities, including the bridge authority). We don't want authorities to check relay or bridge reachability, because tor's 30 minute schedule is too slow.

Everything else just works, because relay reachability self-checks succeed after any inbound connection:
https://gitweb.torproject.org/torspec.git/tree/proposals/311-relay-ipv6-reachability.txt#n498

It's good that authority reachability checks are turned off, because authorities would generate more (spurious) inbound connections.

See my PR:

I'm guessing ahf will want to review this one, because it's based on #33379.

comment:2 Changed 4 months ago by teor

We didn't have CHUTNEY_ALLOW_FAILURES set in chutney's CI, I set it to 2, just like tor.

comment:3 Changed 4 months ago by ahf

The additional patches on top of #33379 looks fine. I'm awaiting CI to go green here.

comment:4 Changed 4 months ago by teor

Status: needs_reviewmerge_ready

CI failed due to a macOS hang, I restarted it, and it passed.

comment:5 Changed 4 months ago by teor

Actual Points: 0.20.3
Parent ID: #33232#33050
Resolution: fixed
Status: merge_readyclosed

Merged to chutney master.

comment:6 Changed 4 months ago by gaba

Keywords: network-team-roadmap-2020Q1 added

Add all the tickets from sponsor 55 that are done and being worked on to the keyword #network-team-roadmap-2020Q1 so I can look at them in the wiki page...

Note: See TracTickets for help on using tickets.