Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#3359 closed defect (fixed)

obfsproxy's socks.c return values are not consistent

Reported by: asn Owned by: asn
Priority: Medium Milestone:
Component: Obfuscation/Obfsproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

#3275 introduced req_status so that network.c can act on the results of handle_socks().
Unfortunately, I suck and most socks functions called by handle_socks() were not returning req_status themselves.

Child Tickets

Change History (3)

comment:1 Changed 7 years ago by asn

Status: newneeds_review

You can find the fix for this in my bug3359 branch.
git://gitorious.org/obfsproxy/obfsproxy.git

comment:2 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good; merging.

comment:3 Changed 6 years ago by arma

Component: Pluggable transportObfsproxy
Note: See TracTickets for help on using tickets.