Opened 8 months ago

Last modified 5 months ago

#33598 assigned defect

chutney does not fail on some SOCKS errors

Reported by: teor Owned by: c
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: ipv6, prop311, outreachy-ipv6, easy
Cc: nickm, c@… Actual Points:
Parent ID: #33050 Points: 1
Reviewer: Sponsor: Sponsor55-can

Description

When tor can't make a connection, and sends back a SOCKS error, chutney keeps on rapidly sending SOCKS requests. Instead, chutney should fail.

I think we introduced this bug when we started using asyncore.

I have worked around the bug using a 5 second asyncore timeout, but we should come up with a permanent fix.

I think nickm might be able to help with this issue, because he wrote that code.

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by teor

Keywords: outreachy-ipv6 added

comment:2 Changed 8 months ago by teor

Cc: teor removed
Parent ID: #33232#33050

comment:3 Changed 7 months ago by teor

Keywords: easy added

comment:4 Changed 5 months ago by c

Cc: c@… added
Owner: set to c
Status: newassigned

Assuming workaround is at Traffic.py:441? I see the timeout was adjusted in 95ce144c which has more changes than just that line.

What's a reproducible way to cause a failure case here? Or, at least, will decreasing the timeout back to 0.2 be enough to encourage failure?

Note: See TracTickets for help on using tickets.