Opened 5 months ago

Closed 4 months ago

#33615 closed defect (fixed)

Wait for at least 60 seconds for 0.3.5 and earlier to bootstrap

Reported by: teor Owned by: teor
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: ipv6, prop311, tor-ci-fail-sometimes, network-team-roadmap-2020Q1
Cc: teor Actual Points: 0.5
Parent ID: #33050 Points: 0.2
Reviewer: ahf Sponsor: Sponsor55-must

Description (last modified by teor)

The basic-min network is still a bit unstable, but only for 0.3.5. (And it's much more unrealiable on macOS than Linux.)

It seems like 0.3.5 needs around 60 seconds to bootstrap and sync descriptors. Later versions have microdescriptor download fixes, and they can bootstrap and verify in just over 20 seconds on basic-min.

So let's make the minimum wait time 70 seconds (3 consensuses), if any nodes in the network are running 0.3.5 (or earlier).

Child Tickets

Change History (9)

comment:1 Changed 5 months ago by teor

Keywords: tor-ci-fail-sometimes added

comment:2 Changed 5 months ago by teor

Description: modified (diff)

comment:3 Changed 5 months ago by teor

Description: modified (diff)

comment:4 Changed 5 months ago by teor

Actual Points: 0.5
Reviewer: ahf
Status: assignedneeds_review

See my PR:

I changed chutney to:

  • set a minimum bootstrap time of 65 seconds for 0.3.5 and earlier, before verifying
  • wait an extra 10 seconds for microdesc downloads before verifying (see #33428)
  • wait an extra 30 seconds for onion service descriptor posts before verifying (see #33609)

Once CI passes, I'll merge this CI fix to chutney master, and re-run tor's 0.3.5 chutney job. Then we can do the review some time next week.

comment:5 Changed 5 months ago by teor

Merged to chutney master, restarted the tor CI chutney jobs, also running locally.

Patch seems solid, but I might need to tweak the timings a little.

comment:6 Changed 5 months ago by teor

Fixed a few bugs, waited until CI passed, and merged to master.

I made some test branches for #32792, they also test the latest chutney master:

comment:7 Changed 5 months ago by teor

One macOS job hung, monitoring that issue on #32804.

comment:8 Changed 5 months ago by gaba

Keywords: network-team-roadmap-2020Q1 added

Add all the tickets from sponsor 55 that are done and being worked on to the keyword #network-team-roadmap-2020Q1 so I can look at them in the wiki page...

comment:9 Changed 4 months ago by teor

Resolution: fixed
Status: needs_reviewclosed

This ticket has been working in master for 2 weeks.
It's still pending review, but that's not a high priority, so I'm just going to close it.

Note: See TracTickets for help on using tickets.