Opened 2 months ago

Closed 6 weeks ago

#33630 closed task (fixed)

Retire noisebridge01 default bridge

Reported by: phw Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-bridges, TorBrowserTeam202004R, tbb-9.5a12
Cc: cohosh, tbb-team Actual Points: 0.5
Parent ID: Points:
Reviewer: Sponsor:

Description

Our default bridge noisebridge01 has been running smoothly for years but it's now unmaintained. I contacted each of its former operators repeatedly. Some didn't respond and the ones that did were unable to point me to a new contact. We should therefore remove noisebridge01 from our default bridges. It can still be useful as an ordinary bridge. By removing noisebridge01, we will finally be able to close #13727. I'll push patches for this in a jiffy.

Child Tickets

Change History (11)

comment:1 Changed 2 months ago by phw

Status: newneeds_review
  • Here's a patch for tor-browser-build.
  • Here's a patch for tor-android-service.

comment:2 Changed 2 months ago by gk

Keywords: TorBrowserTeam202003R added

comment:3 Changed 8 weeks ago by pili

Keywords: TorBrowserTeam202004R added; TorBrowserTeam202003R removed

We are no longer in March

comment:4 in reply to:  1 ; Changed 8 weeks ago by boklm

Replying to phw:

  • Here's a patch for tor-browser-build.
  • Here's a patch for tor-android-service.

The patches look good to me. I cherry-picked the tor-browser-build patch to master as commit d479aea502e0ad734f7b31549bdb41a8d20d3251 and to maint-9.0 as commit 2b66ba16b5c41808fff3aed8e34175b317ff10ec. I also updated the ChangeLog.

I did not merge the tor-android-service patch as I don't have write access on this repository.

comment:5 in reply to:  4 Changed 8 weeks ago by sysrqb

Replying to boklm:

Replying to phw:

  • Here's a patch for tor-browser-build.
  • Here's a patch for tor-android-service.

The patches look good to me. I cherry-picked the tor-browser-build patch to master as commit d479aea502e0ad734f7b31549bdb41a8d20d3251 and to maint-9.0 as commit 2b66ba16b5c41808fff3aed8e34175b317ff10ec. I also updated the ChangeLog.

I did not merge the tor-android-service patch as I don't have write access on this repository.

Done. Merged onto tor-android-service master branch. Picked up in tor-browser-build on maint-9.0 with commit b585bdb7440cdac5059e25eaa0553d2e53a29e80 and master with 3636417054f1e739a3a26bbacadbcd252c5a14c2

comment:6 Changed 8 weeks ago by sysrqb

Resolution: fixed
Status: needs_reviewclosed

(And close)

comment:7 Changed 7 weeks ago by dcf

I was surprised to see that commit ac8641d245dadc64f0057231f9e593379e9701fc on the tbb-9.5a11-build1 tag puts back the noisebridge01 bridge. What's the reason for it?

comment:8 in reply to:  7 ; Changed 7 weeks ago by phw

Resolution: fixed
Status: closedreopened

Replying to dcf:

I was surprised to see that commit ac8641d245dadc64f0057231f9e593379e9701fc on the tbb-9.5a11-build1 tag puts back the noisebridge01 bridge. What's the reason for it?


Right around the time we removed noisebridge01, we finally got in touch with a potential maintainer at noisebridge. I asked sysrqb if it was possible to revert the patch, and he did so for the alpha.

It then turned out that our new maintainer would be setting up a new bridge behind a different IP address, so noisebridge01 needs to go after all. I may not have communicated this to sysrqb clearly enough. I'm sorry for the mess.

comment:9 in reply to:  8 Changed 6 weeks ago by sysrqb

Replying to phw:

Replying to dcf:

I was surprised to see that commit ac8641d245dadc64f0057231f9e593379e9701fc on the tbb-9.5a11-build1 tag puts back the noisebridge01 bridge. What's the reason for it?


Right around the time we removed noisebridge01, we finally got in touch with a potential maintainer at noisebridge. I asked sysrqb if it was possible to revert the patch, and he did so for the alpha.

It then turned out that our new maintainer would be setting up a new bridge behind a different IP address, so noisebridge01 needs to go after all. I may not have communicated this to sysrqb clearly enough. I'm sorry for the mess.

Yeah, we had some confusion, but that's okay. I'll delete noisebridge01 from the alpha (nightly) and we can add the new bridge info when that is available.

comment:10 Changed 6 weeks ago by sysrqb

Cc: tbb-team added
Keywords: tbb-9.5a12 added
Status: reopenedmerge_ready

comment:11 Changed 6 weeks ago by sysrqb

Resolution: fixed
Status: merge_readyclosed

I reverted the revert-commits with 121d6597d436e94b92928f39fade8eb2067e6047 and 66d52da6b8b6fccdadc926b85a49109f15ef00ab. I think that should do it.

Note: See TracTickets for help on using tickets.