Opened 5 months ago

Last modified 2 months ago

#33639 assigned defect

Add CHANNEL_CLOSED reason to specs

Reported by: gk Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, 044-should, postfreeze-ok
Cc: atagar Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

I was recently looking at stem debug logs and found

2020-03-17 21:10:58,838 stem [INFO] CIRC event had an unrecognized remote_reason (CHANNEL_CLOSED). Maybe a new addition to the control protocol? Full Event: 'CIRC 6 FAILED $0CDD60E4015EBF2C3B5D32A2B9CC8FE6C98A5C33~UnivUtah3 PURPOSE=GENERAL TIME_CREATED=2020-03-17T20:10:25.388134 REASON=DESTROYED REMOTE_REASON=CHANNEL_CLOSED'

I am not sure how the stem workflow works but I guess it's an implementation based on the spec(s) (not what is actually used/allowed in the tor code).

Thus, we should fix the spec(s) first so we can add the respective stem part later on.

Child Tickets

Change History (5)

comment:1 Changed 5 months ago by gk

It's relevant for REMOTE_REASON, too, which might merit an own ticket as it is missing whatsoever in the control spec.

comment:2 Changed 5 months ago by teor

Keywords: 044-should added
Milestone: Tor: 0.4.4.x-final
Points: 0.5

Let us know if this ticket is part of a sponsor :-)

comment:3 in reply to:  1 Changed 5 months ago by gk

Replying to gk:

It's relevant for REMOTE_REASON, too, which might merit an own ticket as it is missing whatsoever in the control spec.

Actually, that's wrong. The control spec at least is taking care of that.

comment:4 Changed 2 months ago by nickm

Keywords: postfreeze-ok added

Mark tickets which are important or safe enough to look at post-freeze for 0.4.4.

comment:5 Changed 2 months ago by nickm

Owner: set to nickm
Status: newassigned
Note: See TracTickets for help on using tickets.