Opened 7 months ago

Closed 7 months ago

#33665 closed enhancement (fixed)

Add command-line options for unsafe logging

Reported by: dcf Owned by: arlolra
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords:
Cc: cohosh, phw, arlolra, dcf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Moved from comment:4:ticket:33157

Something like that patch was useful when working on #19026 so would you consider merging, https://github.com/keroserene/snowflake/commit/dbd733e4b1430c046ec11e8052efdbac6010e58a

It's okay with me but I would call the option --unsafe-logging instead of --unsafeLogging to match the style of the other options.

In broker/broker.go, yes, dashes are used (ex. disable-tls, acme-email, etc), however, in client/snowflake.go we have camel casing (ex. logToStateDir, keepLocalAddresses, etc)

We should probably consolidate this now. I imagine your preference is for the former?

Child Tickets

Change History (5)

comment:1 Changed 7 months ago by dcf

Status: assignedneeds_review

comment:2 Changed 7 months ago by dcf

Status: needs_reviewneeds_revision

Sorry, I hadn't read the diff thoroughly enough. It's fine with me to stick with the existing convention in each program. And yes, slight preference for --unsafe-logging in the case of proxy-go.

comment:3 Changed 7 months ago by arlolra

Status: needs_revisionneeds_review

I went with -unsafe-logging everywhere and added a second commit to rename the unconventional client flags. Please have a look,
https://github.com/keroserene/snowflake/commits/unsafe

comment:4 Changed 7 months ago by dcf

Status: needs_reviewmerge_ready

Okay, thanks.

Note: See TracTickets for help on using tickets.