Opened 2 months ago

Closed 2 months ago

Last modified 8 weeks ago

#33673 closed enhancement (implemented)

Use the right DLLs and pkg-config path on Appveyor

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.4.2-alpha
Severity: Normal Keywords: tor-ci, appveyor, windows, 035-backport, 041-backport, 042-backport, 043-backport, consider-backport-after-ci-passes
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: ahf Sponsor:

Description

We want to future-proof our Appveyor CI against dll and pkg-config issues.

Split off from #33643, which is the urgent CI fix.

Child Tickets

Change History (5)

comment:1 Changed 2 months ago by teor

Keywords: consider-backport-after-ci-passes added
Status: assignedneeds_review

See my PRs:

Test branches are here:

There's no particular reason to test this fix in master for a few weeks: it either works, or it doesn't. (And Appveyor / mingw aren't going to change their packages again in the next few weeks.)

comment:2 Changed 2 months ago by dgoulet

Reviewer: ahf

comment:3 Changed 2 months ago by ahf

Status: needs_reviewmerge_ready

Looks good.

comment:4 Changed 2 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged to 0.3.5, 0.4.1, and forward.

comment:5 Changed 8 weeks ago by teor

Milestone: Tor: 0.4.4.x-finalTor: 0.3.5.x-final
Note: See TracTickets for help on using tickets.