Opened 2 months ago

Closed 10 days ago

Last modified 10 days ago

#33676 closed enhancement (fixed)

Stop waiting a set time for microdescriptors

Reported by: teor Owned by: anuradha1904
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: ipv6, prop311, outreachy-ipv6
Cc: teor, anuradha1904 Actual Points:
Parent ID: #33050 Points: 0.5
Reviewer: teor Sponsor: Sponsor55-can

Description (last modified by teor)

Your code in #33675 needs to pass your local "make test-network-all", on master and maint-0.3.5, before you start this ticket.

When we make chutney check for microdescriptors, we can stop waiting a set time for microdescriptors to download.

Please read these instructions carefully. Don't leave out any steps!

First, set MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO to 0:
https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L926
https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L952

Then check that make test-network-all still passes on:

  • Tor master, and
  • Tor maint-0.3.5

You can build a different tor branch using the following commands:

git checkout <branch>
make

Check the new code on your own machine, and then submit a pull request to run Chutney's CI.

If all those tests pass, you can remove all the code that uses MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO:

Then add a commit to your pull request with these changes, and check that they pass CI.

You can ignore macOS hangs ("red ! symbol") on Travis CI. It is a bit unstable right now.

Child Tickets

Change History (8)

comment:1 Changed 2 months ago by teor

Description: modified (diff)

comment:2 Changed 7 weeks ago by teor

Hi, you asked for help on IRC, but you're not online right now:

I think we need to fix this issue in #33675, before the maint-0.3.5 build will pass:

if we are not getting the right value for ed25519_id, move _setEd25519Id() into LocalNodeController, so we can use it during wait_for_bootstrap()

comment:3 Changed 6 weeks ago by anuradha1904

Status: assignedneeds_review

comment:4 Changed 6 weeks ago by teor

Hi, when you ask for a review, please put a link to the pull request on the ticket.

comment:5 Changed 6 weeks ago by anuradha1904

Hi teor, this is the link to the PR created https://github.com/torproject/chutney/pull/65
Thank you.

comment:6 Changed 2 weeks ago by teor

Status: needs_reviewneeds_revision

There's still a few things that need to be fixed in this PR, see my comments on the PR.

comment:7 Changed 10 days ago by teor

Resolution: fixed
Status: needs_revisionclosed

Fixed in #33428.

comment:8 Changed 10 days ago by teor

Parent ID: #33428#33050
Note: See TracTickets for help on using tickets.