Opened 7 months ago

Closed 6 months ago

#33685 closed defect (fixed)

Add Support for Building zlib for Android

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004R
Cc: sysrqb, boklm, tbb-team Actual Points:
Parent ID: #28704 Points:
Reviewer: sysrqb Sponsor:

Description

Add android build support for zlib

Child Tickets

Change History (7)

comment:1 Changed 7 months ago by sisbell

Cc: boklm added; gk sisbell eighthave removed
Keywords: TorBrowserTeam202003R added; TorBrowserTeam202003 removed
Status: newneeds_review

comment:2 Changed 7 months ago by pili

Keywords: TorBrowserTeam202004R added; TorBrowserTeam202003R removed

We are no longer in March

comment:3 Changed 7 months ago by pili

Reviewer: sysrqb

comment:4 Changed 6 months ago by sysrqb

zlib needs to be enabled as an input project for tor (in project/tor/config), right?

comment:5 in reply to:  4 Changed 6 months ago by sysrqb

Replying to sysrqb:

zlib needs to be enabled as an input project for tor (in project/tor/config), right?

Ah, I see you added this in #28766. Ignore this comment.

comment:6 Changed 6 months ago by sysrqb

make -j[% c("buildconf/num_procs") %] install

I doubt telling make to parallelize make install does anything, but -j is specified for Windows so I'm okay with keeping them synchronized as there isn't any harm from providing this.

comment:7 Changed 6 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Ah yes, the -j is not very useful on the make install. Although it doesn't seem to cause any harm either.

The patch is now commit cc6e1439cdc0bc393ce7c3c2ece47cc2d9abed4f on master.

Note: See TracTickets for help on using tickets.