Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#3369 closed defect (fixed)

DNS resolver sends empty reply to unsupported query

Reported by: T(A)ILS developers Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: amnesia@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The Tor resolver sends an empty reply (status: NOERROR, QUERY: 1,
ANSWER: 0) rather than an error when it does not support the type of
the query (e.g. MX). This makes it impossible to setup a transparent
torifying DNS proxy frontend that would ask Tor by default, and
fallback to ttdnsd for DNS query types that are unsupported by the
former.

Context: https://lists.torproject.org/pipermail/tor-talk/2011-June/020601.html

Child Tickets

Attachments (1)

0001-client-side-DNS-proxy-server-reply-NOTIMPL-to-unsupp.patch (911 bytes) - added by T(A)ILS developers 9 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by nickm

Milestone: Tor: 0.2.2.x-final
Version: Tor: unspecified

Hm. This ought to be a NOTIMPL, or something else?

comment:2 in reply to:  1 Changed 9 years ago by T(A)ILS developers

Cc: amnesia@… added

Replying to nickm:

Hm. This ought to be a NOTIMPL, or something else?

Right, according to the RFC, NOTIMPL seems the most correct way to reply. Attached patch works for me.

comment:3 Changed 9 years ago by nickm

Status: newneeds_review

Hm. This reverts part of 3b4fa59b. I wonder why we made that change in the first place?

I've thrown the patch and a changelog entry into branch bug3369 in my public repository for easy merging.

comment:4 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

A day later, it still looks okay to me; I can't figure out what that part of 3b4fa59b was for. Maybe we'll find out -- merging this.

comment:5 Changed 8 years ago by nickm

Keywords: tor-client added

comment:6 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.