Opened 5 months ago

Last modified 3 months ago

#33737 new defect

Fix aboutDialog.js error for Firefox nightlies

Reported by: acat Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam202004 ff78-esr
Cc: tbb-team Actual Points:
Parent ID: #33533 Points:
Reviewer: Sponsor: Sponsor58-can

Description

When opening the about dialog, there's a TypeError: can't access property "hidden", document.getElementById(...) is null ... aboutDialog.js:56:14
error which also prevents checking for updates (gAppUpdater is not initialized). It's looking for an element with id communityDesc, which was removed in patch

    Bug 10760: Integrate TorButton to TorBrowser core
    
    Bug 26321: New Circuit and New Identity menu items

This path is only hit with Firefox versions that match /a\d+$/, so we see this now in #33533 because of mozilla-central.

Maybe a fixup for the patch hiding communityDesc instead of removing would be enough for this.

Child Tickets

Change History (2)

comment:1 Changed 4 months ago by pili

Keywords: TorBrowserTeam202004 added; TorBrowserTeam202003 removed

We are no longer in March

comment:2 Changed 3 months ago by acat

Keywords: ff78-esr added
Note: See TracTickets for help on using tickets.