Opened 6 months ago

Last modified 6 months ago

#33784 new enhancement

Think about using `self._relays` in `_relays_with_flag()` and friends

Reported by: gk Owned by:
Priority: Medium Milestone:
Component: Core Tor/sbws Version:
Severity: Normal Keywords:
Cc: juga Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

When we currently call _relays_with_flag() and friends the self.relays property might cause a refresh of relays. This works fine in general but is a) expensive and b) it causes hangs in unit tests in case one uses the property without freeze_time() or even just instantiates a RelayList.

We should think whether we can use self._relays instead. If not in every use case maybe it's possible to use it in some of those cases, though.

Child Tickets

Change History (1)

comment:1 Changed 6 months ago by gk

Description: modified (diff)
Note: See TracTickets for help on using tickets.