Opened 7 months ago

Closed 6 months ago

#33793 closed defect (fixed)

Avoid some race conditions when running chutney networks in series

Reported by: teor Owned by: teor
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: prop311
Cc: ahf Actual Points: 0.3
Parent ID: #33050 Points: 0.3
Reviewer: ahf Sponsor: Sponsor55-must

Description

When chutney runs multiple networks, one after the others, sometimes older tor instances are left running.

To avoid these issues, chutney can:

  • wait longer after terminating tor processes
  • cleanup pid files, so we don't accidentally terminate unrelated processes

Child Tickets

Change History (3)

comment:1 Changed 7 months ago by teor

Reviewer: ahf
Status: assignedneeds_review

See my PR:

I'm going to run it for a while before merging, the timings might need a bit of tuning.

This review isn't urgent or important.

comment:2 Changed 7 months ago by teor

Cc: ahf added; teor removed

I've merged this branch to master, feel free to review it whenever you have time. Or just close it. It's not that important.

comment:3 Changed 6 months ago by teor

Resolution: fixed
Status: needs_reviewclosed

This code has been running successfully in CI for 2 weeks. I don't think a review is necessary.

Note: See TracTickets for help on using tickets.