Opened 7 months ago

Last modified 5 months ago

#33801 merge_ready defect

Upgrade Go Project to use new Android Toolchain

Reported by: sisbell Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, TorBrowserTeam202006R, gitlab-tb-tor-browser-build
Cc: sysrqb, boklm Actual Points: .1
Parent ID: #33184 Points:
Reviewer: gk Sponsor: Sponsor58-must

Description

Go needs to use new NDK path

Child Tickets

Change History (9)

comment:1 Changed 7 months ago by sisbell

Actual Points: .1
Status: newneeds_review

We don't need to specify the API_VERSION for android since this is included in the clang command (shell variant for android)

https://github.com/sisbell/tor-browser-build/commits/bug-33801

comment:2 Changed 7 months ago by gk

Keywords: TorBrowserTeam202004R added

comment:3 Changed 6 months ago by pili

Sponsor: Sponsor58-must

comment:4 Changed 6 months ago by gk

Keywords: tbb-rbm TorBrowserTeam202005R added; Android TorBrowserTeam202004R removed
Reviewer: gk

comment:5 Changed 6 months ago by gk

Priority: MediumHigh

Moving tickets to high prio.

comment:6 Changed 6 months ago by gk

Status: needs_reviewmerge_ready

Looks good to me and works. I've pushed bug_33801 (​https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_33801&id=23df4686e57b66f307aca48c9f1af8b073cd35ba) with a slightly modified commit message and on top of my fenix_toolchain branch.

Last edited 6 months ago by gk (previous) (diff)

comment:8 Changed 5 months ago by gk

Keywords: TorBrowserTeam202006R added; TorBrowserTeam202005R removed

Moving review tickets.

comment:9 Changed 5 months ago by gk

Keywords: gitlab-tb-tor-browser-build added

Add magic gitlab keyword.

Note: See TracTickets for help on using tickets.