Opened 8 weeks ago

Closed 7 weeks ago

#33804 closed defect (fixed)

Defer "PreferIPv6 by default" to 0.4.4

Reported by: teor Owned by: dgoulet
Priority: Very High Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version: Tor: 0.4.3.1-alpha
Severity: Normal Keywords: tor-dns torsocks ipv6 043-must
Cc: Actual Points: 0.1
Parent ID: #33796 Points: 0.1
Reviewer: teor Sponsor:

Description

In #32637, we made clients default to "PreferIPv6" on SOCKSPorts (and other client ports).

But in #33796, we discovered that this change broke torsocks.

We want to defer this change to 0.4.4, so tor can implement IPv4-only and IPv6-only resolves for torsocks.

Since #32637, we have also merged:

  • #33608, which removes a forced PreferIPv6 for non-SOCKSPorts
  • #32994, which puts the PreferIPv6 default in port_parse_config(), rather than in 2 different places in the code

So it should be very easy to change the default for PreferIPv6.

Child Tickets

Change History (5)

comment:1 Changed 7 weeks ago by nickm

Priority: MediumVery High

comment:2 Changed 7 weeks ago by dgoulet

Status: assignedneeds_review

Branch: ticket33804_043_01
PR: https://github.com/torproject/tor/pull/1854

To be clear, this should be merged in 043 ONLY

comment:3 Changed 7 weeks ago by teor

Actual Points: 0.1
Status: needs_reviewmerge_ready

Looks good! Thanks.

Let's merge to 0.4.3 only, after CI passes.

We could make a minor tweak to the man page, to say "PreferIPv6" (rather than "NoPreferIPv6"). But I don't think it matters that much.

comment:4 in reply to:  3 Changed 7 weeks ago by dgoulet

Replying to teor:

We could make a minor tweak to the man page, to say "PreferIPv6" (rather than "NoPreferIPv6"). But I don't think it matters that much.

I've pushed that fixup.

comment:5 Changed 7 weeks ago by teor

Resolution: fixed
Status: merge_readyclosed

Also fixed a typo (IPv4 -> IPv6).

Merged to 0.4.3 only, "ours" merge to master, skipping the changes in this PR.

Note: See TracTickets for help on using tickets.