Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3382 closed defect (invalid)

Improve general code quality of obfsproxy

Reported by: asn Owned by: asn
Priority: Medium Milestone:
Component: Archived/Obfsproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

obfsproxy is heading into a beta state imo
There are some things in the code that still disturb me though and this is the ticket to abolish them.

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by asn

Status: newneeds_review

comment:2 Changed 8 years ago by nickm

In resolve_address_port: There is no requirement that an address contain a ".". Some plausible addresses that do not have one include "localhost" and "[::1]".

comment:3 Changed 8 years ago by nickm

Wow, this is a huge branch full of unrelated stuff. "git diff master...asn/bug3382" gives me almost 4000 lines.

comment:4 Changed 8 years ago by asn

Alright, I splitted this branch into the following five smaller branches:
obfs2spec, protocol_trivial_changes, remove_comments, rm_some_debug_logs and socksc.

comment:5 Changed 8 years ago by asn

Status: needs_reviewassigned

This is outdated.
Pulling it out of needs_review for now.

comment:6 Changed 8 years ago by asn

Resolution: invalid
Status: assignedclosed

Closing this ticket. It's old and useless. Most of these stuff have already been fixed, anyway.

comment:7 Changed 7 years ago by arma

Component: Pluggable transportObfsproxy
Note: See TracTickets for help on using tickets.