Opened 7 months ago

Last modified 5 months ago

#33831 assigned defect

Relays without descriptors are not scaled, but still added to the bwlines without vote=0

Reported by: juga Owned by: juga
Priority: Medium Milestone: sbws: 1.1.x-final
Component: Core Tor/sbws Version: sbws: 1.1.0
Severity: Normal Keywords: sbws-roadmap, intro
Cc: juga Actual Points:
Parent ID: #33121 Points: 1
Reviewer: Sponsor:

Description

As can be seen in: https://gitweb.torproject.org/sbws.git/tree/sbws/lib/v3bwfile.py?h=maint-1.1#n1317

As a result, some relays (in sample data counted ~800) are included in the bandwidth file without its bandwidth scaled, which could be quite different (higher or lower) than the scaled bandwidth.

This is one of the several reasons of #33775.

Child Tickets

Change History (6)

comment:1 Changed 7 months ago by juga

Keywords: intro added

In principle, this is an easy change, but because vote=0 occurs in one part of the code and the scaling where the relays are discarded in other, might be a bit tricky (yup, a big refactor would be great at some point).

comment:2 Changed 7 months ago by juga

What i'd do is to check whether there're descriptor bandwidth values in https://gitlab.torproject.org/torproject/network-health/sbws/-/blob/maint-1.1/sbws/lib/v3bwfile.py#L775 and if not, add something like:

            kwargs['vote'] = 0
            kwargs['unmeasured'] = 1
            return (cls(node_id, 1, **kwargs), "no descriptors")
}}
without adding a new KeyValue to the header.

comment:3 Changed 6 months ago by gk

Keywords: GeorgKoppen202004 added
Owner: set to gk
Status: newassigned

comment:4 Changed 6 months ago by gk

Keywords: GeorgKoppen202005 added; GeorgKoppen202004 removed

Moving my tickets to May.

comment:5 Changed 5 months ago by juga

I think i'm going to need to change the logic on what to do when there is not descriptor observed bandwidth nor consensus bandwidth for #33871, so i think i'll implement this as part of that ticket.
No need then to work on this ticket for now.

comment:6 in reply to:  5 Changed 5 months ago by gk

Keywords: GeorgKoppen202005 removed
Owner: changed from gk to juga

Replying to juga:

I think i'm going to need to change the logic on what to do when there is not descriptor observed bandwidth nor consensus bandwidth for #33871, so i think i'll implement this as part of that ticket.
No need then to work on this ticket for now.

Works for me. :)

Note: See TracTickets for help on using tickets.