Opened 7 months ago

Last modified 5 months ago

#33851 needs_review defect

Patch out Parental Controls detection and logging

Reported by: pospeselr Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam202006R
Cc: tbb-team Actual Points:
Parent ID: #33534 Points:
Reviewer: Sponsor: Sponsor58

Description

We should remove the per-OS implementations of nsIParentalControlsService in /toolkit/components/parentalcontrols and always use the stubbed-out nsParentalControlsServiceDefault.cpp implementation.

When an implementation is present, URIs are sent to an isAllowed(... function that parental control software presumably can hook in the OS to filter content, and a log(...) method also takes in URIs.

Child Tickets

Change History (5)

comment:1 Changed 6 months ago by mcs

We could also remove support for Parental Controls via the --disable-parental-controls configure option. The only problem that Kathy and I see with the configure solution is that some code Firefox assumes the parental controls service is present, i.e.,
https://searchfox.org/mozilla-central/source/browser/extensions/doh-rollout/experiments/heuristics/api.js#11

We could fix that code and try to upstream the patch.

comment:2 Changed 5 months ago by mcs

Cc: tbb-team added
Keywords: TorBrowserTeam202004 added
Owner: changed from tbb-team to mcs

comment:3 Changed 5 months ago by mcs

Keywords: TorBrowserTeam202005R added; TorBrowserTeam202004 removed
Status: assignedneeds_review

It turns out that the only code that assumes that the parental control feature is included is that which I mentioned in comment:1. Since we do not ship the doh-rollout extension, we can just patch our mozconfig files to disable parental controls at build time. Here is a patch:
https://gitweb.torproject.org/user/brade/tor-browser-build.git/commit/?h=bug33851-01&id=eaf9bbfc8216187c6689360f97478ea0ce2d9724

comment:4 Changed 5 months ago by gk

Keywords: TorBrowserTeam202006R added; TorBrowserTeam202005R removed

Moving review tickets.

comment:5 Changed 5 months ago by acat

Looks good to me, but should we also have a Tor Browser mozconfs fixup to keep in sync?

Note: See TracTickets for help on using tickets.