Opened 4 months ago

Last modified 8 weeks ago

#33860 assigned task

Finish test_onionskin_answer()

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, prop311, technical-debt, 044-deferred
Cc: Actual Points:
Parent ID: #33221 Points: 1
Reviewer: Sponsor: Sponsor55-can

Description

In #33633, we finished unit tests for test_extend() and helpers.

But we didn't have time to finish test_onionskin_answer().

Let's try to test each of the cases of each if statement in onionskin_answer(). It's ok to mock the functions that are called by onionskin_answer().

Child Tickets

Change History (2)

comment:1 Changed 4 months ago by teor

Owner: set to nickm
Parent ID: #33220#33221
Status: newassigned

It would be great to have unit tests here, but they are not urgent or required.

If you find other tasks more interesting, please feel free to do them first.

I expect the onionskin_answer() code will change in #33221, so we have some time before this task needs to be done.

comment:2 Changed 8 weeks ago by nickm

Keywords: 044-deferred added
Milestone: Tor: 0.4.4.x-finalTor: unspecified

Bulk-remove tickets from 0.4.4. Add the 044-deferred label to them.

Note: See TracTickets for help on using tickets.