Opened 6 months ago

Last modified 5 months ago

#33873 assigned defect

client: Send back SOCKS extended error F6 in case of bad hostname

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, tor-client, socks, 044-must, postfreeze-ok
Cc: mcs, brade Actual Points:
Parent ID: Points: 0.1
Reviewer: asn Sponsor: Sponsor27-must

Description

With the new awesome TB 9.5a11, the SocksPort ExtendedErrors are being handled.

Passing an invalid v3 address that is of the right length in bytes, will send back the F6 error but not for an invalid address like: asijdijasdoijqwoieqw.onion.

Problem is that we only send back the F6 code if the address was identified, by length, as a v3. We should handle the BAD_HOSTNAME error code from parse_extended_hostname() and thus send back that extended error.

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by dgoulet

Sponsor: Sponsor27

comment:2 Changed 5 months ago by nickm

Keywords: 044-must added
Sponsor: Sponsor27Sponsor27-must

comment:3 Changed 5 months ago by nickm

Keywords: postfreeze-ok added

Mark tickets which are important or safe enough to look at post-freeze for 0.4.4.

Note: See TracTickets for help on using tickets.