Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#33917 closed defect (fixed)

Make IF_BUG_ONCE() support ALL_BUGS_ARE_FATAL

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.1-alpha
Severity: Normal Keywords: ipv6, prop311, prop312, technical-debt
Cc: Actual Points: 0.2
Parent ID: #33048 Points: 0.2
Reviewer: ahf Sponsor: Sponsor55-must

Description

... and DISABLE_ASSERTS_IN_UNIT_TESTS.

It's the only assertion/bug macro that doesn't support these debugging modes. Let's fix that.

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by teor

Status: assignedneeds_review

See my pull request:

This review is not urgent at all.

comment:2 Changed 5 months ago by teor

Parent ID: #33050#33817
Resolution: fixed
Status: needs_reviewclosed

This change conflicts with #33817, so let's review them both in that branch.

comment:3 Changed 5 months ago by teor

Parent ID: #33817#33048
Note: See TracTickets for help on using tickets.