Opened 6 months ago

Last modified 4 months ago

#33927 assigned defect

Add tor-browser-build project for fenix

Reported by: gk Owned by: gk
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, GeorgKoppen202006, TorBrowserTeam202006, gitlab-tb-tor-browser-build
Cc: tbb-team Actual Points:
Parent ID: #33184 Points:
Reviewer: sysrqb Sponsor: Sponsor58-must

Description

We need an own project for Fenix

Child Tickets

Change History (13)

comment:1 Changed 6 months ago by gk

Cc: sisbell sysrqb added

Okay, I spent some time on this and learned a ton. :) bug_33927_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_33927_v2&id=a9eca52f63d049f0cb1a03c14971c8743d79a2b1) builds Fenix successfully. It's not ready for review and I need to file other tickets for issues I encountered on my way, but it compiles. However, only if you allow network access during the build which is due to #33594.

Another gotcha is that we can't use Android SDK 29 out of the box, see comment:13:ticket:33557. We should think about what to do in this case.

comment:2 Changed 6 months ago by gk

Okay, let's track some actual beta here as this makes it easier for all the version tracking of the sub-components: I pushed a follow-up commit bumping the commit used to the latest beta: v4.3.0beta2 which is v4.3.0 as well and requires android-components 38.0.0.

comment:3 in reply to:  1 Changed 6 months ago by gk

Replying to gk:

However, only if you allow network access during the build which is due to #33594.

You are using pip version 10.0.1, however version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

is not very reassuring...

comment:4 Changed 6 months ago by pili

Sponsor: Sponsor58

comment:5 Changed 6 months ago by pili

Sponsor: Sponsor58Sponsor58-must

comment:6 Changed 6 months ago by gk

Keywords: GeorgKoppen202005 added; GeorgKoppen202004 removed

Moving my tickets to May.

comment:7 Changed 6 months ago by gk

Cc: sisbell sysrqb removed
Keywords: tbb-rbm TorBrowserTeam202005 added; Android removed
Reviewer: sysrqb

comment:8 Changed 6 months ago by gk

Priority: MediumHigh

Moving tickets to high prio.

comment:9 Changed 6 months ago by gk

FWIW: https://docs.gradle.org/current/userguide/resolution_rules.html seems useful for getting custom-built geckoview (and android-components) versions used instead of the default ones.

Using the local.properties helpers idea is not overly useful for us I think as it relies on a source code checkout of the dependency and, at least in the GeckoView case, running some mach commands as well.

Last edited 6 months ago by gk (previous) (diff)

comment:10 Changed 5 months ago by gk

For starters I've an updated patch which makes some improvements and is aligned to the geckoview we are currently building in #33973 to make testing the integration easier: bug_33927_v4 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_33927_v4&id=a8b7186849e1115541e60dfbff0636ea47bf9677).

comment:11 Changed 5 months ago by gk

Keywords: GeorgKoppen202006 added; GeorgKoppen202005 removed

Moving my tickets.

comment:12 Changed 5 months ago by gk

Keywords: TorBrowserTeam202006 added; TorBrowserTeam202005 removed

Moving tickets to June.

comment:13 Changed 4 months ago by gk

Keywords: gitlab-tb-tor-browser-build added

Add magic gitlab keyword.

Note: See TracTickets for help on using tickets.