Opened 6 months ago

Last modified 5 months ago

#33930 new defect

Tor binary we build seems to not getting picked up in nightly builds

Reported by: gk Owned by: gk
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-parity, TorBrowserTeam202004, GeorgKoppen202004, gitlab-tb-tor-android-service
Cc: sysrqb, sisbell, tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

We build Tor for Android now ourselves thanks to the fix for #28766. But unfortunately it seems at least as it is not picked up yet, despite #32993 claiming so. I stumbled across this when testing a fix for #32027. The branch has all patches for #28704 and children but it's still shown that we use the Tor we've been bundling so far but not the one we compile.

Child Tickets

Change History (9)

comment:1 Changed 6 months ago by gk

Cc: gk removed
Keywords: GeorgKoppen202004 added
Owner: changed from tbb-team to gk
Status: newassigned

comment:2 Changed 6 months ago by gk

Description: modified (diff)
Summary: Tor binary we build is not picked up in nightly buildsTor binary we build seems to not getting picked up in nightly builds

Okay, I have been looking closer. Looking at the libTor.so we actually ship in nightlies *does* imply that it contains the tor and OpenSSL version we compile (I ran strings over the .so file), so that's good. What is happening is that the binary version check done in tor-android-service is just returning a hard-coded string TOR_VERSION, which is currently set to 0.4.1.5-rc-openssl1.0.2p.

So, we might actually be good here at least with respect to the actually used Tor/OpenSSL version, but that's hard to say. Either way, we need to come up with a better solution than hard-coding given that we support different Tor versions in parallel now.

comment:3 Changed 6 months ago by gk

Priority: HighMedium

comment:4 Changed 6 months ago by gk

Hm, there seems to be no easy way to get the version information at that point. :( So, maybe we should just not emit it then or move it to a later point in the start-up process when we do have it available. It would be good to know the respective Tor version used for debugging help, in particular now that we are starting to use different Tor versions.

Last edited 6 months ago by gk (previous) (diff)

comment:5 Changed 6 months ago by gk

I wonder why we can't just let tor speak directly as on the other platforms. I think that's the ideal solution here. I'll dig a bit...

comment:6 Changed 6 months ago by gk

Parent ID: #28704

comment:7 Changed 5 months ago by gk

Keywords: tbb-rbm removed

comment:8 Changed 5 months ago by gk

Status: assignednew

comment:9 Changed 5 months ago by sysrqb

Keywords: gitlab-tb-tor-android-service added
Note: See TracTickets for help on using tickets.