Document the process to update ssh keys and add/remove users from build-sunet-a.torproject.net

We should document the process to update ssh keys and add/remove users from build-sunet-a.torproject.net. Probably in tools/ansible/README in tor-browser-build.

added TorBrowserTeam202004R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed type::task labels

There is a patch for review in branch bug_33952: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_33952&id=409a0e2a9a27a79ae6b74f8b1816df2fe6bc8d8e

I did not check that the instructions for removing users actually work.

Trac:
Keywords: TorBrowserTeam202004 deleted, TorBrowserTeam202004R added

Trac:
Status: new to needs_review

Replying to boklm:

There is a patch for review in branch bug_33952: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_33952&id=409a0e2a9a27a79ae6b74f8b1816df2fe6bc8d8e

I did not check that the instructions for removing users actually work.

Looks mostly good. Maybe add a sentence about the user dir on the build machine? That's still there after removing the user with your instructions, right?

Some nits:

s/used to setup/used to set up/ s/To update ssh key/To update the ssh key/

Trac:
Keywords: TorBrowserTeam202004R deleted, TorBrowserTeam202004 added
Status: needs_review to needs_revision

Replying to gk:

Replying to boklm:

There is a patch for review in branch bug_33952: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_33952&id=409a0e2a9a27a79ae6b74f8b1816df2fe6bc8d8e

I did not check that the instructions for removing users actually work.

Looks mostly good. Maybe add a sentence about the user dir on the build machine? That's still there after removing the user with your instructions, right?

This should remove the user's home directory too (at least this is what the line remove: yes in roles/tbb-team/tasks/main.yml is supposed to do). I clarified that in: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_33952&id=9ebd1fde48f851ec431dd7cbf03628d1e319d07f

Some nits:

s/used to setup/used to set up/ s/To update ssh key/To update the ssh key/

I fixed that in: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_33952&id=38c7c5be3e1d4826c16eeb9bf3aef2212a6b0be3

I also added a sentence about testing the changes without applying them: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_33952&id=07f3f85c6a4b64e8be7fc2b2173ddc60768b4bdb

The squashed commit is now in branch bug_33952_v2: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_33952_v2&id=513da8008078851501da2e4e9c2d91c4fbfdb5bf

Trac:
Keywords: TorBrowserTeam202004 deleted, TorBrowserTeam202004R added
Status: needs_revision to needs_review

Looks good now, thanks. I tried the removal of users (brade and mcs) and it worked, too. Merged to master with commit 6768a86581b63bfa37279d3144e105faaa35e366.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#33952 (closed)