Opened 7 months ago

Closed 7 months ago

#33956 closed enhancement (fixed)

Define and use TOR_ADDRPORT_BUF_LEN

Reported by: teor Owned by: neel
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactor, technical-debt, prop311, prop312, prop313
Cc: neel Actual Points:
Parent ID: #33048 Points: 0.5
Reviewer: teor Sponsor: Sponsor55-can

Description

In #33918, we discovered a bug where IPv6 addresses were being truncated in logs.

During the fix, we noticed that we had a TOR_ADDR_BUF_LEN, but no equivalent constant for addresses and ports. The new TOR_ADDRPORT_BUF_LEN should allow space for:

  • TOR_ADDR_BUF_LEN
  • IPv6 brackets (2, if not included in TOR_ADDR_BUF_LEN already)
  • the port separator (1)
  • the port (5)

We should check for other truncation errors while making this change.

Child Tickets

Change History (5)

comment:1 Changed 7 months ago by neel

Cc: neel added
Owner: set to neel
Status: newassigned

comment:2 Changed 7 months ago by neel

Status: assignedneeds_review

comment:3 Changed 7 months ago by teor

Milestone: Tor: unspecifiedTor: 0.4.4.x-final
Status: needs_reviewneeds_revision

Thanks!

We need to modify the macro calculation, delete an only comment, and then we should be ok to merge,

comment:4 Changed 7 months ago by neel

Status: needs_revisionneeds_review

Thanks for the feedback.

I made the changes.

comment:5 Changed 7 months ago by teor

Parent ID: #33048
Resolution: fixed
Reviewer: teor
Status: needs_reviewclosed

Thanks!

Squashed and merged to master.

Note: See TracTickets for help on using tickets.