Opened 8 years ago

Closed 8 years ago

#3399 closed defect (fixed)

possible js exception in CookieJarSelector.addProtectedCookie

Reported by: arno Owned by: mikeperry
Priority: Very High Milestone:
Component: TorBrowserButton Version:
Severity: Keywords: MikePerryIteration20110630
Cc: Actual Points: 1
Parent ID: Points: 1
Reviewer: Sponsor:

Description

Hi,
while reading components/cookie-jar-selector.js,
I discovered following code:

var cookies = this.getProtectedCookies(name);


if (cookies.toString() == ""
cookies == null)

cookies = new XML('<cookies/>');

And getProtectedCookies may return null.
If getProtectedCookies returns null, cookies.toString() will throw a TypeError
may be, check could be:

if (cookies == null
cookies.toString() == "")

or ever

if (!cookies)

Child Tickets

Change History (2)

comment:1 Changed 8 years ago by mikeperry

Component: TorbuttonTorBrowserButton
Keywords: MikePerryIteration20110630 added
Points: 1
Priority: normalcritical
Status: newassigned

comment:2 Changed 8 years ago by mikeperry

Actual Points: 1
Resolution: fixed
Status: assignedclosed

Fix pushed to origin/master. Should show up in 1.4.0.

Note: See TracTickets for help on using tickets.