Opened 8 years ago
Closed 8 years ago
#3399 closed defect (fixed)
possible js exception in CookieJarSelector.addProtectedCookie
Reported by: | arno | Owned by: | mikeperry |
---|---|---|---|
Priority: | Very High | Milestone: | |
Component: | TorBrowserButton | Version: | |
Severity: | Keywords: | MikePerryIteration20110630 | |
Cc: | Actual Points: | 1 | |
Parent ID: | Points: | 1 | |
Reviewer: | Sponsor: |
Description
Hi,
while reading components/cookie-jar-selector.js,
I discovered following code:
var cookies = this.getProtectedCookies(name);
if (cookies.toString() == "" cookies == null) cookies = new XML('<cookies/>');
And getProtectedCookies may return null.
If getProtectedCookies returns null, cookies.toString() will throw a TypeError
may be, check could be:
if (cookies == null cookies.toString() == "")
or ever
if (!cookies)
Child Tickets
Change History (2)
comment:1 Changed 8 years ago by
Component: | Torbutton → TorBrowserButton |
---|---|
Keywords: | MikePerryIteration20110630 added |
Points: | → 1 |
Priority: | normal → critical |
Status: | new → assigned |
comment:2 Changed 8 years ago by
Actual Points: | → 1 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Fix pushed to origin/master. Should show up in 1.4.0.