Opened 6 months ago

Last modified 4 months ago

#33991 needs_review task

Remove unused features from rbm

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/rbm Version:
Severity: Normal Keywords: TorBrowserTeam202006R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Some commands in rbm are not used much: rpm, rpmspec, srpm, deb, deb-src, publish, pkg.

Most of them are equivalent to the build command with a --step argument. I think we should simplify things by removing those commands.

Child Tickets

Change History (4)

comment:1 Changed 6 months ago by boklm

In branch bug_33991 I removed a lot of unused features:
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_33991&id=734c902348cf0f912f23465ad802cbffafbfdf85

It should still be possible to re-implement them externally if they are needed. I think this should not affect tor-browser-build, but I have not tested it yet (I will set the ticket in needs_review after doing that).

comment:2 Changed 6 months ago by boklm

Cc: tbb-team added
Summary: Remove unneeded commands from rbmRemove unused features from rbm

comment:3 Changed 6 months ago by gaba

Owner: changed from boklm to tbb-team
Status: newassigned

Release all this tickets back into tbb-team.

comment:4 Changed 4 months ago by boklm

Keywords: TorBrowserTeam202006R added
Status: assignedneeds_review

There is a patch for review in branch bug_33991_v2, removing some unused features:
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_33991_v2&id=24d9a52fe39538e9c5bfdca91fa7301bf91bf690

The branch is based on #34320.

I tested doing a Tor Browser testbuild with this patch.

Note: See TracTickets for help on using tickets.